After Update to 11 "User do not have doctype access via role permission"

ahmed_elgamal · March 2, 2019, 3:10pm

Hi All,

I have just moved to V.11 updating from 10 … upgrade was fin, no errors.

when Manager try to approve a stock entry error message appear, I have not yet tested everything, but every thing seems fin.

oh for extra confusion , order some time get approve with blue error , and in other cases dose not with red error

ahmed_elgamal · March 4, 2019, 8:51pm

any help on this please ?

flexy2ky · March 21, 2019, 2:48pm

I am facing the same issue and raised it about a month ago and no one has picked it up.

From this i see the issue is not unique to me. It is therefore a bug and this post should be categorized as such.

hsow · March 21, 2019, 4:17pm

I’m having the same issue too and I cannot change doctypes

clarkej · March 21, 2019, 4:33pm

Some suggestions -

Maybe check for issues and add or report problems? Issues · frappe/frappe · GitHub

Be sure to update to get latest commit changes for eg fix: More verbose User permission message by netchampfaris · Pull Request #7070 · frappe/frappe · GitHub

github.com

frappe/frappe/blob/develop/frappe/permissions.py#L75


      
          	doctype,
          	ptype="read",
          	doc=None,
          	verbose=False,
          	user=None,
          	raise_exception=True,
          	*,
          	parent_doctype=None,
          ):
          	"""Returns True if user has permission `ptype` for given `doctype`.
          	If `doc` is passed, it also checks user, share and owner permissions.
          
          
	:param doctype: DocType to check permission for
          	:param ptype: Permission Type to check
          	:param doc: Check User Permissions for specified document.
          	:param verbose: DEPRECATED, will be removed in a future release.
          	:param user: User to check permission for. Defaults to current user.
          	:param raise_exception:
          	        DOES NOT raise an exception.
          	        If not False, will display a message using frappe.msgprint
          	                which explains why the permission check failed.

flexy2ky · March 28, 2019, 8:45am

I have raised the issue here:

https://github.com/frappe/frappe/issues/7144

I hope someone picks it up soon.

lasalesi · March 28, 2019, 10:24am

Could it be related to several of the changes introduced to the permission schemes in v11? E.g. also the access to Employees is restriced:

I needed to adjust permissions to get this working after v10 to v11 upgrade. Hope that helps…

flexy2ky · March 28, 2019, 10:29am

Yes while it is connected to changes made to permission schemes in V11, the issue is strange because this happens to users who are not restricted on the doctype via permissions. The users are given broad doctype permissions which removes the Restricted icon visible at the top right end of your screenshot, however the error shown in the screenshot above persists. The first slides in the gif below shows the user does not have Restricted on his purchase order doctype yet the permission error pops up.

What makes it even more weird is the fact that in spite of the permission error which shows up, some of the transactions end up being completed, which means something is not right somewhere as you can see from the image below.

Permission%20Error

clarkej · March 28, 2019, 12:03pm

Be sure to upvote the issue [Tutorial] How to upvote Github issues for non developers

Cat_Yung · April 6, 2019, 6:53am

I have the same problem,

Our member cannot login to our system :
user do not have document access

Anyone has the solution?

Cheers

Cat

flexy2ky · April 9, 2019, 8:25am

Please upvote the issue on GitHub so it can receive attention.

https://github.com/frappe/frappe/issues/7144

Asif_Ashraf · April 10, 2019, 8:41am

i’m also getting the same error while updating the Employee details [doctype Employee]
with role : HR user

But the data updating is happening with error .!
image|690x377

did you get any solution?

Khadija · May 6, 2019, 5:16am

Getting same error after updating to latest update of erpnext v11, was working fine before the update

Tropicalrambler · July 2, 2019, 6:51pm

In our case, on ly one user was affected. Others were not. The curious thing is that there were no differences in their roles, i.e. My user has same privileges over EPRNext than the affected user.

I had the problem with Employees. I managed to solve it, but (BRACE FOR IT) I do not remember how I did it.
Now this user is having the same issue with tasks assigned by other users. He can see tasks fine, but tasks with assignment from others he cannot see.

** EDIT**
Probable solution: Make sure to be logged in as Administrator whenever you change any permissions.
Even if the Role Permissions are set per doctype, just check to make sure they are.
Go to the user. Remove the roles. Save. Add the roles back again. Save.
This should restore visibility and unrestrict the doctypes.

rachanna · July 3, 2019, 2:09pm

Have you solved this issue?

Khadija · July 3, 2019, 3:47pm

The error was while viewing the reports but I don’t remember what I did to resolve it

clarkej · July 3, 2019, 7:41pm

ok the learning for next time - be sure to note whatever you learn here, then you can search back to remind yourself

flexy2ky · July 4, 2019, 1:49pm

The permission issues were fixed via:

github.com/frappe/frappe

fix(permission): Permission failure message

frappe:hotfix ← surajshetty3416:perm-message-fix

opened 12:28PM - 07 Feb 19 UTC

surajshetty3416

+3 -1

- Show permission failure message only if permission is checked for session user… (other internal permission checks for other users should not be shown to the logged in user) Eg. There is a feature where we create workflow actions for the users so that they can see all pending approvals that they can do. We create these workflow actions when a document(which has workflow enabled) is saved. While creating workflow action, it checks if the users with a specific role have permission to access the document before creating a workflow action doc against them. Previously these checks used to result in following msgprints after the document(which had workflows enabled for them) is saved ![photo_2019-02-07_17-56-36](https://user-images.githubusercontent.com/13928957/52412683-7fc5a180-2b05-11e9-8f67-da4913cb8eff.jpg)

and

github.com/frappe/frappe

fix: unexpected permission message while creating address

frappe:hotfix ← surajshetty3416:fix-permission-message-while-creating-address

opened 04:53AM - 18 Feb 19 UTC

surajshetty3416

+6 -6

**Before** ![permission_message_address_1](https://user-images.githubuserconten…t.com/13928957/52928709-3841df80-3367-11e9-9f97-f6b59ea005ed.gif) **After** ![permission_message_address](https://user-images.githubusercontent.com/13928957/52928741-498aec00-3367-11e9-88c9-743be6eaf881.gif)

See

github.com/frappe/frappe

After Update to 11 “User do not have doctype access via role permission”

opened 12:06PM - 27 Mar 19 UTC

closed 02:14PM - 13 Jun 19 UTC

flexy2ky

This Error shows up when users try to process a purchase transaction. Appropriat…e user permissions are assigned as shown in the post below: https://discuss.erpnext.com/t/after-update-to-11-user-do-not-have-doctype-access-via-role-permission/46278 The perception is that it is related to the below PR: https://github.com/frappe/frappe/blob/8081ad1c38f3c73dae34c003b1e013df3d972f7f/frappe/permissions.py#L75 can this error be looked into?

Khadija · July 9, 2019, 11:58am

Now that I rechecked still have not resolved this, it was showing on “employee balance leaves” report as I did not have much time I left it as it is that only managers can view that report. For other employees it still shows this error

Khadija · July 9, 2019, 12:02pm

I am using the master branch as the development branch is not stable, but most of commits are still not merged in master branch. Which branch should I use?