Cannot save a document for a custom doctype

Oliver_Faulkner · March 20, 2020, 2:49pm

Ive tried to make a custom doctype but im getting this error when i try to save a new document of that type

Traceback (most recent call last): File “/home/oliver/frappe-bench/apps/frappe/frappe/app.py”, line 62, in application response = frappe.api.handle() File “/home/oliver/frappe-bench/apps/frappe/frappe/api.py”, line 55, in handle return frappe.handler.handle() File “/home/oliver/frappe-bench/apps/frappe/frappe/handler.py”, line 22, in handle data = execute_cmd(cmd) File “/home/oliver/frappe-bench/apps/frappe/frappe/handler.py”, line 61, in execute_cmd return frappe.call(method, **frappe.form_dict) File “/home/oliver/frappe-bench/apps/frappe/frappe/init.py”, line 1054, in call return fn(*args, **newargs) TypeError: savedocs() missing 2 required positional arguments: ‘doc’ and ‘action’

Home

Status: 500

what is happening here

snickbit · April 2, 2020, 4:31pm

@Oliver_Faulkner I’m running into the same issue. Did you ever resolve this?

clarkej · April 2, 2020, 5:07pm

Pointers like this may help How to extend core code using custom app

snickbit · April 2, 2020, 5:24pm

This isn’t a custom function. This error is coming from attempting to create a new DocType from within the GUI as directed here: Not Found

The form seems to be sending a post request with “doc” and “action” parameters to /api/method/frappe.desk.form.save.savedocs but the function doesn’t seem to be getting them.

github.com

frappe/frappe/blob/4b8567170c517526c393579765fa6647dc4adbf2/frappe/desk/form/save.py#L9


      
          # Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
          # MIT License. See license.txt
          
          
from __future__ import unicode_literals
          import frappe, json
          from frappe.desk.form.load import run_onload
          
          
@frappe.whitelist()
          def savedocs(doc, action):
          	"""save / submit / update doclist"""
          	try:
          		doc = frappe.get_doc(json.loads(doc))
          		set_local_name(doc)
          
          
		# action
          		doc.docstatus = {"Save":0, "Submit": 1, "Update": 1, "Cancel": 2}[action]
          
          
		if doc.docstatus==1:
          			doc.submit()

Screenshot from chrome DevTools:
2020-04-02--131335

clarkej · April 2, 2020, 5:43pm

So example code that creates a DocType via the api would point the way here…

edit:

github.com

frappe/frappe/blob/4b8567170c517526c393579765fa6647dc4adbf2/frappe/tests/test_api.py#L33


      
          			{"doctype": "Note", "public": True, "title": "of"},
          			{"doctype": "Note", "public": True, "title": "sixpence"},
          		])
          
          
		self.assertTrue(frappe.db.get_value('Note', {'title': 'Sing'}))
          		self.assertTrue(frappe.db.get_value('Note', {'title': 'a'}))
          		self.assertTrue(frappe.db.get_value('Note', {'title': 'song'}))
          		self.assertTrue(frappe.db.get_value('Note', {'title': 'of'}))
          		self.assertTrue(frappe.db.get_value('Note', {'title': 'sixpence'}))
          
          
	def test_create_doc(self):
          		server = FrappeClient(get_url(), "Administrator", "admin", verify=False)
          		frappe.db.sql("delete from `tabNote` where title = 'test_create'")
          		frappe.db.commit()
          
          
		server.insert({"doctype": "Note", "public": True, "title": "test_create"})
          
          
		self.assertTrue(frappe.db.get_value('Note', {'title': 'test_create'}))
          
          
	def test_list_docs(self):
          		server = FrappeClient(get_url(), "Administrator", "admin", verify=False)

github.com

frappe/frappe/blob/4b8567170c517526c393579765fa6647dc4adbf2/frappe/frappeclient.py#L94


      
          			"fields": fields,
          		}
          		if filters:
          			params["filters"] = json.dumps(filters)
          		if limit_page_length:
          			params["limit_start"] = limit_start
          			params["limit_page_length"] = limit_page_length
          		res = self.session.get(self.url + "/api/resource/" + doctype, params=params, verify=self.verify, headers=self.headers)
          		return self.post_process(res)
          
          
	def insert(self, doc):
          		'''Insert a document to the remote server
          
          
		:param doc: A dict or Document object to be inserted remotely'''
          		res = self.session.post(self.url + "/api/resource/" + doc.get("doctype"),
          			data={"data":frappe.as_json(doc)}, verify=self.verify, headers=self.headers)
          		return frappe._dict(self.post_process(res))
          
          
	def insert_many(self, docs):
          		'''Insert multiple documents to the remote server

snickbit · April 2, 2020, 6:40pm

The code you have referenced seems to be about creating new items of a doctype that already exists. I really can’t see how creating a new item record will help me create a new table. Maybe there’s a miscommunication, let me try explaining further.

I’m working on a shipping label app. I’m trying to create a new “shipment” doctype. The documentation says to go to Developer > Documents > DocType > New to create this. The form in that location fails and gives an error stating that the “doc” and “action” parameters are missing from the post request. The post request shows that it did in fact send those parameters.

I feel like i might be missing a step, but I can’t find anything on it.

snickbit · April 2, 2020, 6:57pm

I resolved this. My module was not setup correctly. Following the details in the post below with a new app allowed me to get through the error.

clarkej · April 2, 2020, 11:34pm

Ah yes, you wished to define a new DocType, not create a new instance of an existing one…