Employee naming by employee number

ejaaz · November 9, 2024, 9:33am

Override this method and set your naming series in it.

frappe/erpnext/blob/4ea2071265d524e1e09280ec8fe70d8861d1bda6/erpnext/setup/doctype/employee/employee.py#L29


      
          	pass
          
          
          class InactiveEmployeeStatusError(frappe.ValidationError):
          	pass
          
          
          class Employee(NestedSet):
          	nsm_parent_field = "reports_to"
          
          	def autoname(self):
          		set_name_by_naming_series(self)
          		self.employee = self.name
          
          	def validate(self):
          		from erpnext.controllers.status_updater import validate_status
          
          		validate_status(self.status, ["Active", "Inactive", "Suspended", "Left"])
          
          		self.employee = self.name
          		self.set_employee_name()

manal_erpnext · November 9, 2024, 9:40am

i name it by employee number

ejaaz · November 9, 2024, 9:53am

Have you done this by overriding the autoname method?

manal_erpnext · November 12, 2024, 1:08pm

no i just override the validation method by copy all the code and pased it then just change the status

manal_erpnext · November 12, 2024, 1:10pm

as this said Last app will work what does it mean? - #2 by NCP

the naming by employee number will work just if i did oppesite the documentation ?!
mean if i reorder the hrms to be after my app !!

ejaaz · November 12, 2024, 5:54pm

Same as this

ejaaz · November 12, 2024, 5:57pm

So you mean to order like this?

Frappe
erpnext
my_app
hrms… etc

Then check your custom app’s customizations. Maybe in your custom app’s customizations, it is set as ‘Employee naming series.’ And if I remember correctly, you have set the employee name by employee number in HR settings?

manal_erpnext · November 13, 2024, 7:14am

yes
but now i create new site and from hr setting i but the name to be employee number every thing rn well
then i create new app and add property setter to add some else status for employee and i custom the validate method by override it in my app by add just the new status
then run migrate then restart the services but the naming does not work in but order
hrms then test_app the status worked and the naming not and in test_app then hrms the naming worked but the status not

manal_erpnext · November 13, 2024, 7:23am

this all code i add to custom
and this is the property setter

as you see in the Module (for export) i select module of my test app but i search about it in side app i did not find it?

i just add this in hook file

manal_erpnext · November 14, 2024, 12:49pm

When I override the validate function in employee to add new cases, the autoname function which exist in the employee doctype was called, even when the Employee Settings of Employee Naming By in the HR settings select the employee number. This behavior was contrary to the usual behavior that call the autoname method in employee master. Therefore, the autoname function was also override to resemble the usual behavior.

ejaaz · November 14, 2024, 2:29pm

That’s what I said earlier ; it’s good that you found the solution .

manal_erpnext · November 16, 2024, 6:33am

yes i override it
but

i did not set my naming series
i could say i just change the behavior i did not set my naming series and i did not add any code as you offer and thx for your help all the time with your ideas and i learn form you a lot