ERPNext and single sign on (SSO)

zamis · May 28, 2023, 7:19pm

hi there!
I found out that looks like it’s possible to link Keycloack and Erpnext via Custom Social Login.
And I tried to connect them together.

But I faced a strange problem and got an error.
I tried it quite a few times with different settings but every time I faced similar error.

x

Traceback (most recent call last):
  File "apps/frappe/frappe/website/serve.py", line 18, in get_response
    response = renderer_instance.render()
  File "apps/frappe/frappe/website/page_renderers/template_page.py", line 84, in render
    html = self.get_html()
  File "apps/frappe/frappe/website/utils.py", line 510, in cache_html_decorator
    html = func(*args, **kwargs)
  File "apps/frappe/frappe/website/page_renderers/template_page.py", line 95, in get_html
    self.update_context()
  File "apps/frappe/frappe/website/page_renderers/template_page.py", line 163, in update_context
    data = self.run_pymodule_method("get_context")
  File "apps/frappe/frappe/website/page_renderers/template_page.py", line 225, in run_pymodule_method
    return method(self.context)
  File "apps/frappe/frappe/www/login.py", line 82, in get_context
    "auth_url": get_oauth2_authorize_url(provider.name, redirect_to),
  File "apps/frappe/frappe/utils/oauth.py", line 63, in get_oauth2_authorize_url
    flow = get_oauth2_flow(provider)
  File "apps/frappe/frappe/utils/oauth.py", line 91, in get_oauth2_flow
    oauth2_providers = get_oauth2_providers()
  File "apps/frappe/frappe/utils/oauth.py", line 42, in get_oauth2_providers
    out[provider.name]["auth_url_data"] = json.loads(provider.auth_url_data)
  File "/usr/local/lib/python3.10/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/usr/local/lib/python3.10/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/local/lib/python3.10/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Here my social login settings:

Maybe someone has ideas how I can deal with it?

I found different links but didn’t find an answer:

https://frappeframework.com/docs/v14/user/en/guides/integration/social_login_key

github.com/frappe/frappe

Custom Social Login via Gitlab failed

opened 03:02PM - 09 May 20 UTC

closed 04:24PM - 09 May 20 UTC

ch9hn

bug

## Description of the issue When Gitlab as Custom OAuth Provider is used in ERPnext, the social login failed with: `json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)` ## Context information (for bug reports) Social Login Configuration: **Name:** gitlab **Client ID:** SECRET **Client Secret:** SECRET **Icon:** fa fa-gitlab **Base URL:** https://gitlab.mydomain.com **Authorize URL:** /oauth/authorize **Access Token URL:** /oauth/token **Redirect URL:** https://erp.mydomain.com/api/method/frappe.integrations.oauth2_logins.custom/gitlab **API Endpoint:** /users **Output of `bench version`** ``` 5.0.0 ``` ## Steps to reproduce the issue 1. Enter Social Login details from Provider 2. Log out 3. Login via Gitlab 4. Gitlab processing Login 5. Redirect to ERPNext 6. Error occurs ### Observed result Login doesnt work, error show up ### Expected result Social Login from ERPNext to Gitlab works ### Stacktrace / full error message ``` [ERROR] 2020-05-09 16:46:09,648 | /home/frappe/frappe-bench/apps/frappe/frappe/utils/error.py: Could not take error snapshot: invalid syntax (<string>, line 1) Traceback (most recent call last): File "/home/frappe/frappe-bench/apps/frappe/frappe/app.py", line 60, in application response = frappe.api.handle() File "/home/frappe/frappe-bench/apps/frappe/frappe/api.py", line 55, in handle return frappe.handler.handle() File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 22, in handle data = execute_cmd(cmd) File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 61, in execute_cmd return frappe.call(method, **frappe.form_dict) File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 1051, in call return fn(*args, **newargs) File "/home/frappe/frappe-bench/apps/frappe/frappe/integrations/oauth2_logins.py", line 50, in custom login_via_oauth2(provider, code, state, decoder=decoder_compat) File "/home/frappe/frappe-bench/apps/frappe/frappe/utils/oauth.py", line 112, in login_via_oauth2 info = get_info_via_oauth(provider, code, decoder) File "/home/frappe/frappe-bench/apps/frappe/frappe/utils/oauth.py", line 145, in get_info_via_oauth info = session.get(api_endpoint, params=api_endpoint_args).json() File "/home/frappe/frappe-bench/env/lib/python3.7/site-packages/requests/models.py", line 897, in json return complexjson.loads(self.text, **kwargs) File "/usr/local/lib/python3.7/json/__init__.py", line 348, in loads return _default_decoder.decode(s) File "/usr/local/lib/python3.7/json/decoder.py", line 337, in decode obj, end = self.raw_decode(s, idx=_w(s, 0).end()) File "/usr/local/lib/python3.7/json/decoder.py", line 355, in raw_decode raise JSONDecodeError("Expecting value", s, err.value) from None json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0) During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/frappe/frappe-bench/apps/frappe/frappe/utils/error.py", line 36, in make_error_snapshot snapshot = get_snapshot(exception) File "/home/frappe/frappe-bench/apps/frappe/frappe/utils/error.py", line 132, in get_snapshot value = eval(value) File "<string>", line 1 <built-in method with_traceback of JSONDecodeError object> ^ ``` ## Additional information Ubutnu 18.04 Docker version 19.03.8 Install via: https://github.com/Monogramm/docker-erpnext ERPNext, Version: 12.7-Debian

PS: I already have experience in linking NextCloud and Keycloak and I thought that it should be similar but I couldn’t.