Error in Email Links Formatting [V12]

[flexy2ky]

Email links generated by auto email alerts are wrongly formatted at destination:

Fore instance, this is the link found in email queue:

https://erp.octo5.co/project/?name=3DHeron’s Beak Development

This is the link received in mail:

https://erp.octo5.co/proj=ct/?name=Heron's%20Beak%20Development

As you can see, the link received has an error in project and this has been noticed across all auto email alerts generated for password resets.

Also, when I retrieve the password reset link manually, after changing password, I get to an error 404 page saying page not found. Either it has been moved or no longer exists. So essentially password changes are not being confirmed. These errors could be linked as the error screenshot is the same.

Screenshot 2019-08-23 at 12.40.18 PM

[Iulian_Olaru]

I have a similar situation with e-mail links for the events… the link to the event contains a port :8002

[clarkej]

Upvote the issue GitHub · Where software is built

[Tutorial] How to upvote Github issues for non developers

In the recent foundation call, we discussed on how to better engage the community with respect to features being developed. Here is the link to a one minute tutorial on how to upvote Github issues. Please upvote the issues so that developers get to know what community members would like them to work on. Thanks

[flexy2ky]

I have upvoted it. Let’s hope it gets looked at as soon as possible. It’s a drag having to manually reset passwords for users. This is not ideal.

[Andrew_McLeod]

I have seen the same issue (equals signs appearing randomly) in other emails, such as from Contact Us and email document notifications.

[Andrew_McLeod]

Equal sign in emails

So the issue is because the emails are going out in quoted printable, and I think ERPNext isn’t quite doing it right and Microsoft is being Microsoft. In quoted printable, the correct line ending is CRLF, but ERPNext is only outputting LF. Microsoft, being Microsoft, is not dealing with this at all well… The addition of the line: message = message.replace(‘\n’, ‘\r\n’) at line 440 of frappe/email/queue.py ‘fixes’ this although it probably messes up other things (binary data?).