Fix for Issue #42738: Crash in parse_latest_non_beta_release due to non-semver tags

PrasadAlai · September 15, 2026, 6:18pm

Hi everyone,
I recently submitted a pull request (frappe/frappe#42861) to fix an issue where update checks crash when encountering non-semver release tags (such as custom descriptive tags like v14-baseline).

The Problem

When parsing GitHub releases via parse_latest_non_beta_release, the function attempts to parse every tag string into a semantic_version.Version object. If a repository contains non-semver compliant tags, it raises an uncaught ValueError, causing update checks to crash (fixes #42738).

The Fix

I updated parse_latest_non_beta_release in frappe/utils/change_log.py to loop through releases and safely wrap version parsing in a try...except ValueError block so that invalid semantic version strings are silently skipped. I also added a comprehensive regression test.

Request for Vouching / Review

Since my account isn’t vouched yet, the initial PR was automatically closed by the automated bot. I would love some feedback on this fix or help from a maintainer / vouched member to get added to the VOUCHED.td list so I can reopen and merge it.

Here is a link to my closed PR for reference:

github.com/frappe/frappe

skip non-semver tags in parse_latest_non_beta_release

develop ← 321prasad0058:fix/issue-42738-non-semver-tags

opened 02:01PM - 15 Sep 26 UTC

321prasad0058

+51 -3

## Problem When parsing GitHub releases via `parse_latest_non_beta_release`, …the function attempts to parse every tag string into a `semantic_version.Version` object. If a repository contains non-semver-compliant tags, such as custom descriptive tags like `v14-baseline`, it raises an uncaught `ValueError`, causing update checks or release tracking to crash. Fixes #42738 ## Solution Updated `parse_latest_non_beta_release` in `frappe/utils/change_log.py` to wrap version parsing inside a `try...except ValueError` block. Invalid semantic version strings are now safely skipped, while valid versions continue to be processed normally. ## Before ```python version_list = [ release.get("tag_name").strip("v") for release in response if not release.get("prerelease") ] ``` ## After ```python version_list = [] for release in response: if not release.get("prerelease"): v = release.get("tag_name", "").strip("v") try: Version(v) version_list.append(v) except ValueError: continue ``` ## Impact * **Crash Prevention:** Stops unhandled exceptions and application crashes during system updates or release checks when encountering non-standard tags. * **Improved Fault Tolerance:** Ensures release parsing logic can gracefully handle repositories with mixed or custom tag formats without failing entirely.

Thank you for your guidance and support!