Hi,
One important point, PR use case should be assigned an owner who is leading test and merge since we are community based sometimes things get lost in between contributors, for any reason also valid reasons project engagement or what ever.
PR test owner will follow PR till the end or find another owner to do handover.
rgds
Rohan figured out discourse integration
So our current idea is to create a Discuss post everytime a build succeeds on the server (we’re only doing builds via manual requests right now to save server resources).
The Discuss post will contain some basic information about the Github PR (along with a description if it has one) and also provide a way to access the testing site.
This really sounds like a policy change. Automatically tagging both the requesters and the contributors with users across Github and Discuss is going to be a bigger problem.
The next best thing right now should be the Discuss post I shared above, where anyone can go in and test, and leave their feedback for the contributor(s).
Do let us know what you think, and we’d appreciate feedback on any improvements to be made.
This is a great Initiative and it might help us be part of the development process. An option to contribution (or atleast an opportunity to contribute) is now available at PR level.
Updates,
I added listing and details page for Improvement, check https://board.castlecraft.co.in. Guest Users can list, filter and view improvements.
Request to Review flow is up.
This will create requests that mods can delete, approve or reject from desk view.
Flow for mods to take actions is not yet added. Review Requests Logic · Issue #27 · revant/erpnext_feature_board · GitHub
Hi @revant_one,
Do you think this could apply as PR?
I haven’t received any useful answer and I’m sure this tool worked as explained, I used it all the time before upgrade to v11.
PR means Pull Request. If you fix the issue on your own in your frappe / erpnext fork code hosted on your server and it works for you and if you wish to share that with everyone you can send it as a PR. This is where you contribute to core.
In case you just need to solve the problem immediately, the issue seem to be around the “Supplier Quotation Comparison” report. Copy that report in separate custom app, rename it, make changes you need. This is where you create your custom app.
By looking at the closed Issue I feel there is gap between developer’s expectation from the feature and your expectation from the feature. That might take time to resolve. You can choose custom app option to solve your problem immediately.
Only the Improvement(s) with “Deployment Status” that is “Ready” will have a website.
check the ones with ready here: https://board.castlecraft.co.in sort by deployment status and you will see. Right now only 1 is running https://board.castlecraft.co.in/improvement?name=GH-IMP-2021-00192
I scaled down the cluster to 2 nodes to save some credits.
I didn’t know people are really using this! that is great!
What are the login credentials for this instance?
It would be great, if credentials are shown in the board itself for each instance.
The link if anyone is looking for this one PR. Dont know the u/password
https://gh-imp-2021-00192.castlecraft.co.in/#login
got to any ready instance
click on Review Request:
Select Add Testing User:
Click on the user to see password
Moderator has to approve this request, If you do it now, I’ll approve immediately.
If you want a site for this PR then click “Request to Review” and select “Build”, It’ll be in for moderation again.
“Request to Review” button seems to be restricted to logged in users only and I am unable to sign up using email.
can you signin with google?
I’ve not set email account. I don’t wish to add my email account.
This PR was tested using the system. Now it is merged.
The app https://github.com/revant/erpnext_feature_board is not developed any more.
Core features that it had:
build images from fork of frappe or erpnext based on PR. i.e It helps you build bench with forked frappe, erpnext and custom apps.
It deployed the images on cluster as flux/helmrelease using kubernetes api. Helm release was based on configurable helm source. i.e. It helps deploy custom benches with additional services or resources.
I extracted out the core api into separate fastapi and kopf app, It is improved and sanity tested. Hope it helps whoever wants to use it.
Potential use cases for this api and operator - build your own PR review system, SaaS sites, custom bench based PaaS.
For more: castlecraft / k8s_bench · GitLab
DO NOT use it if not familiar with Kubernetes or not already using Kubernetes.
