@auliabismar well i did not have any inclination that this was not production-ready. If i had known i would not have pushed the update to my production instance. Moreover, there were other fixes with the update which i needed in my production environment so you could say i had no choice since i could not have been able to pick and choose which update to install.
Notification is completely broken now for me but at least my instance works. I just hope the developers of the new feature will look at the issue and try to fix it.
i tried your suggestions and it seemed not to have fixed the issue so i figured i had one more process to try so i ran sudo bench build and restarted the server afterwards and it fixed the problem. My guess is the frappe and erpnext asset rebuild process broke the last time hence the error
@clarkej it’s possible that this issue is tied to that one. My investigations revealed that when i created the custom notification for Expense Claim, i checked “Is Standard” and that created an expense_claim_request.py file. However, this file referenced a non-existent Expense Claim module and that caused the Expense Claim Request to break. Deleting the files, custom email alert and running bench migrate and then bench build fixed that issue as well.
Lesson Learnt: Never assume that every feature in ERPNext is failure-proof
Never take for granted the possibility that your production environment might be
broken by a verified PR or New Feature
Most Importantly: Always test every newly released update on a test server with a mirror of your
production server and verify everything is well before pulling any update.
But why are open documents by default always collapsed? There are many users who have used the badge to quickly navigate to other relevant documents. This was click badge - click on doctype (2 clicks), now it is click on notification center, click to expand open documents, click on doctype (3 clicks). I know it seems like this is only one click, but 100 times one additinal click per day is just not efficient.
Why not have open documents always expanded? Or have configurable what is expanded? When I click enabled → unchecked, there is actually no impact…
Is this really stable? I believe this should rather be in a testing branch…
@prssannad Okay, so the new notification Center breaks all default Email Alerts configured. For instance, instead of a new user receiving the “Welcome to Company Name” Email Notification, what they receive is
Subject: Administrator shared a document User User Name with you
This is not good. While the effort to consolidate notification is good, defaulting all standard email alerts to this essentially renders customized notifications useless. Please this should be reversed.
Thanks for sharing, @flexy2ky. Wow, this is highly critical! How can a new breaking feature be introduced yet again in a minor (actually only bugfix) version release? Fully agree on reverting this, classical email alerts are in place in so many cases, reinventing this is a huge hurdle for companies using ERPNext…
@flexy2ky@lasalesi , It doesn’t break default Email Alerts configured; the user still receives the Welcome email.
I’ve created a PR that prevents the sending of “Subject: Administrator shared a document User User Name with you” email though, thanks for pointing it out
As a workaround for now you can disable email notifications for Document Share from Notification Settings (Default email alerts configured will still be received).
@prssannad If i may suggest, you should make the notification settings global. Not all users have the time or patience to go setup notifications and the system admin cannot go to each and every user to disable notification types.
@prssannad I see that this PR has been merged into develop branch. It doesn’t fix the document share issue for me since it’s in develop. Any chance this could be merged in Version 12 or any tips on how I can pull the merge to my instance? This shared document mail is a pain and still occurs even though the shared document is unchecked in notifications settings.