Leave application, incorrect used leaves

[ishanloya]

When I create a new Leave Application, in the Dashboard, the number of used leaves is being calculated incorrectly. I think it’s taking into account the number of leave applications approved for an employee but not taking into account half day leaves. So for e.g.:

In case of 4 leave application of which 2 are full day applications and 2 are half day applications, the used leaves are being shown as 4 instead of 3.

[clarkej]

Here is a similar observation

(V12) Employee leave balance report is reporting wrong leave balance if employee has taken half day leave

The half day leave which has been taken by employee is taken as full day leave by the report. I looked at the code in leave_application.py, the function get_leaves_for_period doesn’t seem to be considering half day leave at all. It simply: leave_days += get_number_of_leave_days(employee, leave_type, leave_entry.from_date, leave_entry.to_date) * -1 And those employees who have taken half day leaves are having wrong leave balance.

[ishanloya]

Thanks @clarkej. Yes, this is the same issue.