Naming series reset issue

[clarkej]

You are allowed only one naming_series template and here you seem to have two.

Assuming you wish to generate a distinct series for your two STE types, 11 and 22, then define the naming_series say CODE-STE-.#####.-.YY.

Then in Stock Entry doctype add a Custom Field that contains a Select field named ‘code’ the lists Options 11 & 22. (So when a Stock Entry instance is created, you select either those option that is ‘pulled’ or substituted into the naming_series.)

Finally in the controller stock_entry.py define this

def autoname(self):
#key = “CODE-STE-.#####.-.YY.”
key = self.get(“autoname”)
name = frappe.model.naming.make_autoname(key)
self.name = name.replace(“CODE”,self.code)

[mdwala]

@clarkej

s for your two STE types, 11 and 22

Hi Clarkej,

I think since I only posted few details you didnt get my queries, Apology. Attaching all.

+-----------------------------+---------+
| name                        | current |
+-----------------------------+---------+
| PATCHLOG                    |     610 |
| CHF-B                       |       1 |
| STE-                        |       0 |
| SLE/                        |   34799 |
| BIN/                        |     350 |
| GL                          |  116852 |
| [Select]                    |       0 |
| ITEM-PRICE-                 |     299 |
| CHF-B-                      |       2 |
| RGF-                        |      25 |
| CST-                        |      52 |
| CMB-AP-                     |       7 |
| SMSLOG/                     |     810 |
| SINV-                       |       0 |
| CMB-FP-{{customer_name}}-   |       1 |
| CMB-FP-customer_name-       |      17 |
| PR                          |       0 |
| PE-                         |      12 |
| CMB-RF-                     |       0 |
| JV-                         |       0 |
| 11-SINV-                    |       0 |
| 12-SINV-                    |       4 |
| 22-SINV-                    |      10 |
| SINV-RET-                   |       0 |
| PO-                         |       0 |
| PREC-                       |       0 |
| PREC-RET-                   |       0 |
| PINV-                       |       0 |
| PINV-RET-                   |       0 |
| 11-APT-                     |       6 |
| 11-RFL-                     |     217 |
| 12-RFL-                     |       0 |
| 22-RFL-                     |       0 |
| 11-FWU-                     |   10254 |
| 12-FWU-                     |       0 |
| 22-FWU-                     |       0 |
| 12-APT-                     |       0 |
| 22-APT-                     |       0 |
| 11-REG-                     |    1429 |
| 12-REG-                     |       8 |
| 22-REG-                     |       0 |
| 11-PINV-                    |      12 |
| 12-PINV-                    |       0 |
| 22-PINV-                    |       0 |
| 11-PINV-RET-                |       0 |
| 12-PINV-RET-                |       0 |
| 22-PINV-RET-                |       0 |
| 11-PREC-                    |       0 |
| 12-PREC-                    |       0 |
| 22-PREC-                    |       0 |
| 11-PREC-RET-                |       0 |
| 12-PREC-RET-                |       0 |
| 22-PREC-RET-                |       0 |
| 11-PO-                      |       0 |
| 12-PO-                      |       0 |
| 22-PO-                      |       0 |
| 11-SINV-RET-                |       0 |
| 12-SINV-RET-                |       1 |
| 22-SINV-RET-                |       1 |
| 11-DN-                      |       0 |
| 12-DN-                      |       0 |
| 22-DN-                      |       0 |
| 11-DN-RET-                  |       0 |
| 12-DN-RET-                  |       0 |
| 22-DN-RET-                  |       0 |
| 11-MREQ-                    |       0 |
| 12-MREQ-                    |       0 |
| 22-MREQ-                    |       0 |
| 11-PRO-                     |       0 |
| 12-PRO-                     |       0 |
| 22-PRO-                     |       0 |
| 11-QTN-                     |       0 |
| 12-QTN-                     |       0 |
| 22-QTN-                     |       0 |
| 11-SO-                      |       0 |
| 12-SO-                      |       0 |
| 22-SO-                      |       1 |
| 11-STE-                     |      70 |
| 12-STE-                     |       0 |
| 22-STE-                     |      65 |
| 11-SQTN-                    |       0 |
| 12-SQTN-                    |       0 |
| 22-SQTN-                    |       0 |
| 11-CUST-                    |       5 |
| 12-CUST-                    |       0 |
| 22-CUST-                    |       0 |
| 11-JV-                      |     523 |
| 22-JV-                      |       4 |
| I-                          |  101550 |
| RET-                        |       0 |
| OPTY-                       |       0 |
| INVTD                       |       8 |
| LEAD-                       |       1 |
| CS-{schedule_date}-         |       1 |
| CS-schedule_date-           |       2 |
| CS-{{schedule_date}}-       |       2 |
|  CS-13-06-17-max_occupancy- |       1 |
|  CS--                       |       2 |
| CS-                         |      11 |
| EV                          |       3 |
| BAT-                        |       0 |
| A-                          |       0 |
| A-RET-                      |       0 |
| AD-                         |       0 |
| 22-STE-00010-               |       0 |
| 22-STE-00030-               |       0 |
| LCV                         |       7 |
| 22-STE-00038-               |       0 |
| 22-STE-00040-               |       0 |
| 22-STE-00041-               |      50 |
| 11-STE-00067-               |      64 |
| 11-STE-00069-               |      64 |
| 22-STE-00046-               |       0 |
| 22-ST-                      |       2 |
| 22-STE-00050-               |       0 |
| 22-STE-00054-               |       0 |
| 22-STE-00055-               |       0 |
+-----------------------------+---------+
117 rows in set (0.00 sec)

.
.
.

.
.
.

.
.
.

[clarkej]

Please your feedback on my previous post…

[clarkej]

This may clarify how to ‘separate’ the naming series for a given DocType.

Customizing naming series - #5 by Sangram

I am undecided which solution method is best practice…

[mdwala]

Hi clarkej.

I dont get why I needs to change stock_entry.py or any other modification.

As per my attached snapshot everything is in standard way if should be.

Can you please explain why further modifications requires for new stock entry for different company using new naming series!

[clarkej]

"
As per my attached snapshot everything is in standard way if should be.

Can you please explain why further modifications requires for new stock entry for different company using new naming series!
"

I am not sure what you mean by standard way.

Please explain your way so we can troubleshoot why it does not work for you?

[mdwala]

Hi Clarkej,

Thanks for replying.

@clarkej

I am not sure what you mean by standard way.

Please explain your way so we can troubleshoot why it does not work for you?

There are two naming series
11-STE-.#####.-.YY for Company A
22-STE-.#####.-.YY for Company B

Company A is having above 150 entry with 11-STE and using ##### in correct order.

I do not have any entry for 22-STE-.#####.-.YY yet.

But when doing stock entry for Company B with 22-STE-.#####.-.YY; it is using ##### as 22-STE-00055-17. I can’t understand why? It should be 22-STE-00001-17.

Naming series setup is as per instruction from user manual(Standard way).

Thanks again!

[clarkej]

Thanks for restating your problem mdwala

Now the big question…

Either of these two example series is possible (of course)

11-STE-00001-17
11-STE-00002-17
11-STE-00003-17
22-STE-00001-17
22-STE-00002-17
22-STE-00003-17

or this

11-STE-00001-17
11-STE-00002-17
11-STE-00003-17
22-STE-00004-17
22-STE-00005-17
22-STE-00006-17

But in your business case spec only one of them is ‘correct’ or ‘proper’

The question is which one?

My guess is you want or expect the first one but get the second one?

Of course I may be ‘wrong’

From what you tell or show me to now, I am not exactly sure

[mdwala]

@clarkej

11-STE-00001-17

11-STE-00002-17

11-STE-00003-17

22-STE-00001-17

22-STE-00002-17

22-STE-00003-17

This is what I want

But note below

• 11-STE last id is 11-STE-00157-17, and thus it already has
  11-STE-00001-17
  TO
  11-STE-00157-17

• 22-STE is taking numbers as
  00050
  00051
  00052
  00053

• Althogh I do not have any 22-STE stockentry, Why +50? Why not 1, 2, 3…

[clarkej]

inspect your db for more clues where the problem may be

MariaDB [d56cb677eaab3383]> select name,current from tabSeries where name like'%STE%';
MariaDB [d56cb677eaab3383]> select name,naming_series from `tabStock Entry`;

Here’s an eg case Naming Series Current Value Is not Updating from naming series form - #5 by clarkej

[mdwala]

both command gives
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ‘%s for update’ at line 1

[mdwala]

We got wrong understanding while setting up naming series at beginning.

Series to be reset to 1 on prefix change: prefix to be requires prior “#####”
11-STE-.#####.-.YY is wrong

it should be
11-STE-.YY.-.#####

Our Submitted entries messed up because of this wrong setup, but at least found the issue.

@mdwala

Hi,

I have set two series in stock entry as

11-STE-.#####.-.YY

22-STE-.#####.-.YY

11-STE-.#####.-.YY is working properly and using correct serial numbers.

But with 22 I dont have any entry but when I save new stock entry it uses number above 52…

After deleting 22-STE-00052-17, when I go to naming series current value for 22-STE is still 0.

Clicking update series number with 0 doesnt change anything.

New stock entry still creates 53, I repeat same above, it creates 54!

What am I missing?

[clarkej]

Good problem solved - thanks for your followup learning mdwala

[kolate_sambhaji]

@mdwala

@mdwala

We got wrong understanding while setting up naming series at beginning.

Sorry, I have not added documentation in frappe core while developing feature adding fields in naming series.

Its long overdue due to some other open issue with naming series.

1. Currently we can not add auto suffix like .YY.-INV-.###
2. Naming series need to move in frappe core from erpnext, so one can use it for custom app without having erpnext app.
3. Rules for naming to avoid special charter avoid from naming series as it break url

[mdwala]

@kolate_sambhaji

@mdwala

11-STE-.YY.-.#####

But as I mentioned it is working properly with above format.

Also didn’t get your 3rd point. What is special charter?

[kolate_sambhaji]

@mdwala You can not use .YY. in first place of naming series.

Also if you use slash “/” then URL will break when you share URL of document. Generally in Email we have URL for document. There are some URL encode mechanism we can do or we can avoid special charter from name
e.g for Invoice SBK/SINV/00001, url will be
erp.domain.com//desk#Form/Sales%20Invoice/SBK/SINV/00001

[mdwala]

@kolate_sambhaji

You can not use .YY. in first place of naming series.

Why we can’t use .YY. as in my reply?

1. Is it issue with core? Or
2. Is it not possible? As It is already generating id for me properly at the moment.

@kolate_sambhaji

[mdwala]

@kolate_sambhaji

You can not use .YY. in first place of naming series.

Update
Spoke with @kolate_sambhaji\

No-one should use as YY-STE-11-#####, but
STE-11-YY-##### will surely work.

[vishnu1]

Hi,

I have created a series list in Sales Order, the list are BJAP.YY.MM.### and VJAP.YY.MM.###, the naming series does not auto increment.

for example:
BJAP.YY.MM.2106001 will be my first order
VJAP.YY.MM.2106001 again the second order will be of same sequence
BJAP.YY.MM.2106002 for next order

Please help me to find how to increment the each order as below:
BJAP.YY.MM.2106001
VJAP.YY.MM.2106002
BJAP.YY.MM.2106003
VJAP.YY.MM.2106004

Thank you,
Vishnu

[vishnu1]

Hi,

I have created a series list in Sales Order, the list are BJAP.YY.MM.### and VJAP.YY.MM.###, the naming series does not auto increment.

for example:
BJAP.YY.MM.2106001 will be my first order
VJAP.YY.MM.2106001 again the second order will be of same sequence
BJAP.YY.MM.2106002 for next order

Please help me to find how to increment the each order as below:
BJAP.YY.MM.2106001
VJAP.YY.MM.2106002
BJAP.YY.MM.2106003
VJAP.YY.MM.2106004

Thank you,
Vishnu