Overriding Plugin Method

TSping1 · December 23, 2025, 3:33am

Hello all!

I have been trying to create a hook to replace the functionality of an erpnext method, “calculate_taxes_and_totals”, found in “erpnext/erpnext/controllers/taxes_and_totals.calculate_taxes_and_totals”.

As far as I can see, the hook lists “override_whitelisted_methods” (to replace the method directly) and “override_doctype_class” (to replace the entire class) are only for core DocType classes, not those introduced by plugins.

I’d prefer to avoid monkey patching, as it seems to be used for a quick fix, not for permanent use.

Summary: How can I override a method in a plugin?

Sudhanshu · December 23, 2025, 4:20am

there is no harm to use monkey patch if you use it properly.
and for your scenario monkey patch is the solution.

Yamen_Zakhour · December 23, 2025, 7:21am

github.com/frappe/semgrep-rules

rules/frappe_correctness.yml

d01e207b1


      
          - id: frappe-monkey-patching-not-allowed
            patterns:
              - pattern-either:
                - pattern: |
                    from $X import $Y
                    ...
                    $Y.$PROPERTY = ...
                - pattern: |
                    from $X import $Y
                    ...
                    $Y.$Z.$PROPERTY = ...
                - pattern: |
                    from $X import $Y
                    ...
                    $Y.$Z.$F.$PROPERTY = ...
                - pattern: |
                    from $X import $Y
                    ...
                    $Y.$Z.$F.$K.$PROPERTY = ...
                - pattern: |

This file has been truncated. show original

Sudhanshu · December 23, 2025, 9:30am

you can use this patching from hooks.

just add same import code in hooks and it will work.

TSping1 · December 24, 2025, 1:08am

Hello Yamen,

Just wanting to get some clarification on this message - is this some sort of intrinsic Frappe file that disallows coding faux pas, or is it a check people can run on installed plugins to make sure they behave?

I’m not sure what this message means as a whole.

Yamen_Zakhour · December 24, 2025, 8:04am

Please go through this discussion