Setting up role permission

Ujjawal · November 17, 2016, 1:18pm

So the user permission is automatically created for that employee…
Actually it was removed.
Because whenever i set exit interviewer for the employee the user cannot see the profile anymore…
Can you check that at your end.
After setting the exit interviewer for the employee.

Dbone · November 17, 2016, 1:25pm

I don’t have an “Exit Interviewer” field. Where do you see it?

Ujjawal · November 17, 2016, 1:27pm

Sorry I Have Created a custom field in Employee.
So whenever i set the field to some employee, the profile is no longer available to the employee.
I dont get the reason for it.

Dbone · November 17, 2016, 2:02pm

It’s just a guess but having 2 user id’s on the Employee doctype might be triggering:

github.com

frappe/erpnext/blob/d5ebd79ad7bda2f13e9b6f4e6487f3aafa3d1bd4/erpnext/hr/doctype/employee/employee.py#L50


      
          		self.validate_status()
          		self.validate_employee_leave_approver()
          		self.validate_reports_to()
          
          
		if self.user_id:
          			self.validate_for_enabled_user_id()
          			self.validate_duplicate_user_id()
          		else:
          			existing_user_id = frappe.db.get_value("Employee", self.name, "user_id")
          			if existing_user_id:
          				frappe.permissions.remove_user_permission(
          					"Employee", self.name, existing_user_id)
          
          
	def on_update(self):
          		if self.user_id:
          			self.update_user()
          			self.update_user_permissions()
          
          
	def update_user_permissions(self):
          		frappe.permissions.add_user_permission("Employee", self.name, self.user_id)
          		frappe.permissions.set_user_permission_if_allowed("Company", self.company, self.user_id)

I suggest you create a new user and employee record and confirm that everything works as it should BEFORE adding anything in your custom field. Also, unless it’s critical to link to an employee, you could use a Data filed instead and just type the interviewers name in.

Depends on how many employees leave or get fired I suppose…

Ujjawal · November 18, 2016, 7:42am

hi @Dbone
But how can i hide a custom button based on permission?
I mean i have created a custom button in employee.
and he is able to view that button so can i hide that button?
I want only HR User or Manager to view that Button.

umair · November 18, 2016, 9:04am

Try Perm Level.

https://frappe.github.io/erpnext/user/manual/en/setting-up/articles/managing-perm-level

Ujjawal · November 18, 2016, 9:32am

Its a custom button added using script.
I have not added it using customize form.

Dbone · November 18, 2016, 11:19am

Please share all the customisations you have made to the employee doctype. Scripts and fields. Everyone can help you better this way.

Ujjawal · November 18, 2016, 1:30pm

I have added the button using script

cur_frm.add_custom_button(__(“Allocate Leave”),function(){
frappe.call({
method:“erpnext.hr.doctype.employee.employee.allocate_leave”,
args:{
employee:cur_frm.doc.employee,
conf_date:cur_frm.doc.final_confirmation_date,
leave_type:“Privilege Leave”,
joining_date:cur_frm.doc.date_of_joining
},
callback:function(){frappe.msgprint(“Leaves Allocated”)}
});
});

I want to hide the button created using this script.
The button which is in toolbar.