Why is validation of Select Type Fields skipped in Data Import?

Vamyip 2018-07-27 14:12:24 UTC #1

Hello,

My users reported that in Data Import, fields of Link Type are validated by not Select Types.

I found that validation for Select Types is specifically skipped when data import is going on.

frappe/frappe/blob/1922dcc87fd93cca5561a7c23c230b52caaafb31/frappe/model/base_document.py#L484


						invalid_links.append((df.fieldname, docname, get_msg(df, docname)))


					elif (df.fieldname != "amended_from"
						and (is_submittable or self.meta.is_submittable) and frappe.get_meta(doctype).is_submittable
						and cint(frappe.db.get_value(doctype, docname, "docstatus"))==2):


						cancelled_links.append((df.fieldname, docname, get_msg(df, docname)))


		return invalid_links, cancelled_links


	def _validate_selects(self):
		if frappe.flags.in_import:
			return


		for df in self.meta.get_select_fields():
			if df.fieldname=="naming_series" or not (self.get(df.fieldname) and df.options):
				continue


			options = (df.options or "").split("\n")


			# if only empty options

Wanted to know if there is a specific purpose for doing so and whether I can contribute in any way to implement a better solution to the problem.

Its very common for users to make typos and this validation will really help.

Thanks,
Vamyip