Add domain to self hosted session

Hi everybody
Is this the right way to add a domain
I am self hosted using vmbox on windows
I would like to take this online using static IP

bench setup add-domain --site site1.local
bench setup nginx
sudo service nginx restart

will the above procedure do the job or am i missing anything


yes, this should work.

of course you also need the according DNS entries to point to your server.

I would also recommend setting up SSL.

This command may mess up your existing Nginx configuration. Better directly edit Nginx configuration. We have documented it here

Thanks for the reply
The above code i used worked perfectly
Thanks again
With Regards