Adding Naming Series to Contract default DocType

mr-elamin · April 13, 2023, 12:10pm

Hello,

there is a standard doctype for Contracts but this doctype has no naming series.
I have customized this doctype by adding the “select” data field type with the “naming_series”, as you see that in this screenshot:

then I select the naming Series:

then I setup the naming series for the contract:

unfortunately, the change never take affect when I create a new contract.
the naming series that I am getting is the “party name” but not my defined naming series:

I appreciate any help.
Thank you very much
Adil

mr-elamin · April 13, 2023, 12:27pm

What ever I customize in the doctype “contract”
nothing take affect except “Set by user” Naming rule.

NCP · April 13, 2023, 12:31pm

Hi @mr-elamin,

When you save the doc, the backend script worked so does not have any effect on your naming series.
Please check it in base.

github.com

frappe/erpnext/blob/develop/erpnext/crm/doctype/contract/contract.py#L12-L23


      
          	def autoname(self):
          		name = self.party_name
          
          
		if self.contract_template:
          			name += " - {} Agreement".format(self.contract_template)
          
          
		# If identical, append contract name with the next number in the iteration
          		if frappe.db.exists("Contract", name):
          			count = len(frappe.get_all("Contract", filters={"name": ["like", "%{}%".format(name)]}))
          			name = "{} - {}".format(name, count)
          
          
		self.name = _(name)

Thank You!

mr-elamin · April 13, 2023, 1:22pm

Hi @NCP
Thank you very much for your answer,
I have removed the lines from 12 till 23 and after I restarted the container the naming series takt the affect!
Thank you again for your help

YogiYang · April 14, 2023, 5:55am

Hello,

I am curious to know why this behavior is hard coded bypassing the Naming Series features provided by FrappeFramework and not documented?

TIA

Yogi Yang

vipeesh-pavithran-19 · May 5, 2025, 10:57am

I have encountered a strange situation today. I have deleted one contract row in between and then now am trying to add new contract it showing the name exist. I think it because of the logic of getting the count with name.

Am not sure in practical the Contract can be deleted. But am seeing a logical issue here