Adjust Webhook timeout

Armando_Carrion · December 12, 2022, 2:58pm

Greetings,

It seems like webhooks have an internal timeout were, if the endpoint takes too much time sending a response, it tries again and sends another request.

Is there a way to adjust the timeout or disable this behaviour?

Thanks in advance for your answer.

PD: My test endpoint is on ngrok, and i added a timeout of 10s for testing this.

revant_one · December 12, 2022, 3:13pm

there is no such feature. timeout is set to 5. retries are set to 3.

if you wish you can add configuration field on webhook and use it in requests and send a pull request.

https://requests.readthedocs.io/en/latest/user/advanced/#timeouts

code that will change:

github.com

frappe/frappe/blob/e4cb215ad2838eb7c9780f6c68eda00997f61c45/frappe/integrations/doctype/webhook/webhook.py#L119-L144


      
          	for i in range(3):
          		try:
          			r = requests.request(
          				method=webhook.request_method,
          				url=webhook.request_url,
          				data=json.dumps(data, default=str),
          				headers=headers,
          				timeout=5,
          			)
          			r.raise_for_status()
          			frappe.logger().debug({"webhook_success": r.text})
          			log_request(webhook.request_url, headers, data, r)
          			break
          
          
		except requests.exceptions.ReadTimeout as e:
          			frappe.logger().debug({"webhook_error": e, "try": i + 1})
          			log_request(webhook.request_url, headers, data)
          
          
		except Exception as e:
          			frappe.logger().debug({"webhook_error": e, "try": i + 1})

This file has been truncated. show original

Armando_Carrion · December 13, 2022, 1:26pm

Oh, alright, I just wanted to make sure before trying something in the code. Thanks.