Bench error on install-app when using hook required_apps

1

Hi,

I am testing the required_apps hook. Bench is version 5.8.1, frappe branch is develop.

Whenever I have the hook:

required_apps = ["erpnext"]

in the hooks.py file I get the following error (even if erpnext is installed):

An error occurred while installing case_management_patent: 
Traceback (most recent call last):
  File "apps/frappe/frappe/installer.py", line 173, in fetch_details_from_tag
org, repo = org_repo
ValueError: not enough values to unpack (expected 2, got 1)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "apps/frappe/frappe/commands/site.py", line 344, in install_app
    _install_app(app, verbose=context.verbose)
  File "apps/frappe/frappe/installer.py", line 223, in install_app
    name = parse_app_name(name)
  File "apps/frappe/frappe/installer.py", line 203, in parse_app_name
    _, repo, _ = fetch_details_from_tag(name)
  File "apps/frappe/frappe/installer.py", line 175, in fetch_details_from_tag
    org, repo = find_org(org_repo[0])
  File "apps/frappe/frappe/installer.py", line 149, in find_org
    raise InvalidRemoteException
frappe.exceptions.InvalidRemoteException

Any idea what the problem may be? Is it a bug in bench?

Thanks!
DoCa

2

This has broken in bench again more recently. The solution seems to be to specify the org/account so that the install works correctly. For example, hrms version-14 required_apps is broken and should be

required_apps = ["frappe/erpnext"]

When working with your own dependencies, you need to specify the org/account as well:

required_apps = ["frappe/erpnext", "frappe/hrms", "agritheory/check_run"]
3

I’ve made a PR to fix this in hrms v14