Bench run-tests

Frappe Framework App Development
1

Hi,

I’m looking at unit testing module (to reopen a PR missing testing file) and plan to add my method test_item_search() in test_item.py because I need test items but the run-tests command crashes on last develop branch (some test datas seem not created)

bench run-tests --doctype "item"

Traceback (most recent call last):
File “/usr/lib/python2.7/runpy.py”, line 162, in _run_module_as_main
“main”, fname, loader, pkg_name)
File “/usr/lib/python2.7/runpy.py”, line 72, in _run_code
exec code in run_globals
File “/home/britlog/frappe-bench/apps/frappe/frappe/utils/bench_helper.py”, line 94, in
main()
File “/home/britlog/frappe-bench/apps/frappe/frappe/utils/bench_helper.py”, line 18, in main
click.Group(commands=commands)(prog_name=‘bench’)
File “/home/britlog/frappe-bench/env/local/lib/python2.7/site-packages/click/core.py”, line 700, in call
return self.main(*args, **kwargs)
File “/home/britlog/frappe-bench/env/local/lib/python2.7/site-packages/click/core.py”, line 680, in main
rv = self.invoke(ctx)
File “/home/britlog/frappe-bench/env/local/lib/python2.7/site-packages/click/core.py”, line 1027, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File “/home/britlog/frappe-bench/env/local/lib/python2.7/site-packages/click/core.py”, line 1027, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File “/home/britlog/frappe-bench/env/local/lib/python2.7/site-packages/click/core.py”, line 873, in invoke
return ctx.invoke(self.callback, **ctx.params)
File “/home/britlog/frappe-bench/env/local/lib/python2.7/site-packages/click/core.py”, line 508, in invoke
return callback(*args, **kwargs)
File “/home/britlog/frappe-bench/env/local/lib/python2.7/site-packages/click/decorators.py”, line 16, in new_func
return f(get_current_context(), *args, **kwargs)
File “/home/britlog/frappe-bench/apps/frappe/frappe/commands/init.py”, line 24, in _func
ret = f(frappe._dict(ctx.obj), *args, **kwargs)
File “/home/britlog/frappe-bench/apps/frappe/frappe/commands/utils.py”, line 319, in run_tests
ui_tests = ui_tests)
File “/home/britlog/frappe-bench/apps/frappe/frappe/test_runner.py”, line 57, in main
ret = run_tests_for_doctype(doctype, verbose, tests, force, profile)
File “/home/britlog/frappe-bench/apps/frappe/frappe/test_runner.py”, line 130, in run_tests_for_doctype
make_test_records(doctype, verbose=verbose, force=force)
File “/home/britlog/frappe-bench/apps/frappe/frappe/test_runner.py”, line 223, in make_test_records
make_test_records(options, verbose, force)
File “/home/britlog/frappe-bench/apps/frappe/frappe/test_runner.py”, line 224, in make_test_records
make_test_records_for_doctype(options, verbose, force)
File “/home/britlog/frappe-bench/apps/frappe/frappe/test_runner.py”, line 266, in make_test_records_for_doctype
frappe.local.test_objects[doctype] += test_module._make_test_records(verbose)
File “/home/britlog/frappe-bench/apps/erpnext/erpnext/accounts/doctype/account/test_account.py”, line 65, in make_test_records
} for account_name, parent_account, is_group, account_type, currency in accounts])
File “/home/britlog/frappe-bench/apps/frappe/frappe/test_runner.py”, line 311, in make_test_objects
d.insert()
File “/home/britlog/frappe-bench/apps/frappe/frappe/model/document.py”, line 192, in insert
self.run_before_save_methods()
File “/home/britlog/frappe-bench/apps/frappe/frappe/model/document.py”, line 772, in run_before_save_methods
self.run_method(“validate”)
File “/home/britlog/frappe-bench/apps/frappe/frappe/model/document.py”, line 666, in run_method
out = Document.hook(fn)(self, *args, **kwargs)
File “/home/britlog/frappe-bench/apps/frappe/frappe/model/document.py”, line 887, in composer
return composed(self, method, *args, **kwargs)
File “/home/britlog/frappe-bench/apps/frappe/frappe/model/document.py”, line 870, in runner
add_to_return_value(self, fn(self, *args, **kwargs))
File “/home/britlog/frappe-bench/apps/frappe/frappe/model/document.py”, line 660, in
fn = lambda self, *args, **kwargs: getattr(self, method)(*args, **kwargs)
File “/home/britlog/frappe-bench/apps/erpnext/erpnext/accounts/doctype/account/account.py”, line 33, in validate
self.validate_parent()
File “/home/britlog/frappe-bench/apps/erpnext/erpnext/accounts/doctype/account/account.py”, line 48, in validate_parent
throw((“Account {0}: Parent account {1} does not exist”).format(self.name, self.parent_account))
File “/home/britlog/frappe-bench/apps/frappe/frappe/init.py”, line 319, in throw
msgprint(msg, raise_exception=exc, title=title, indicator=‘red’)
File “/home/britlog/frappe-bench/apps/frappe/frappe/init.py”, line 309, in msgprint
_raise_exception()
File “/home/britlog/frappe-bench/apps/frappe/frappe/init.py”, line 282, in _raise_exception
raise raise_exception(encode(msg))
frappe.exceptions.ValidationError: Account _Test Bank - _TC: Parent account Bank Accounts - _TC doesn’t exist

2

Maybe a test dependency - so run one of these first?

./apps/erpnext/erpnext/accounts/doctype/account/test_account.py
./apps/erpnext/erpnext/setup/doctype/company/test_company.py

3

Thanks, I tried to run tests on theses doctypes first, but it is still crashing.
So I launch a full bench run-tests as explained in frappe docs :
https://frappe.io/docs/user/en/guides/automated-testing/unit-testing

But I’ve an error, please see the traceback below

Traceback (most recent call last):
  File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/home/britlog/frappe-bench/apps/frappe/frappe/utils/bench_helper.py", line 94, in <module>
    main()
  File "/home/britlog/frappe-bench/apps/frappe/frappe/utils/bench_helper.py", line 18, in main
    click.Group(commands=commands)(prog_name='bench')
  File "/home/britlog/frappe-bench/env/local/lib/python2.7/site-packages/click/core.py", line 700, in __call__
    return self.main(*args, **kwargs)
  File "/home/britlog/frappe-bench/env/local/lib/python2.7/site-packages/click/core.py", line 680, in main
    rv = self.invoke(ctx)
  File "/home/britlog/frappe-bench/env/local/lib/python2.7/site-packages/click/core.py", line 1027, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/britlog/frappe-bench/env/local/lib/python2.7/site-packages/click/core.py", line 1027, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/britlog/frappe-bench/env/local/lib/python2.7/site-packages/click/core.py", line 873, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/britlog/frappe-bench/env/local/lib/python2.7/site-packages/click/core.py", line 508, in invoke
    return callback(*args, **kwargs)
  File "/home/britlog/frappe-bench/env/local/lib/python2.7/site-packages/click/decorators.py", line 16, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/britlog/frappe-bench/apps/frappe/frappe/commands/__init__.py", line 24, in _func
    ret = f(frappe._dict(ctx.obj), *args, **kwargs)
  File "/home/britlog/frappe-bench/apps/frappe/frappe/commands/utils.py", line 319, in run_tests
    ui_tests = ui_tests)
  File "/home/britlog/frappe-bench/apps/frappe/frappe/test_runner.py", line 61, in main
    ret = run_all_tests(app, verbose, profile, ui_tests)
  File "/home/britlog/frappe-bench/apps/frappe/frappe/test_runner.py", line 103, in run_all_tests
    test_suite, ui_tests)
  File "/home/britlog/frappe-bench/apps/frappe/frappe/test_runner.py", line 207, in _add_test
    make_test_records(doctype, verbose)
  File "/home/britlog/frappe-bench/apps/frappe/frappe/test_runner.py", line 223, in make_test_records
    make_test_records(options, verbose, force)
  File "/home/britlog/frappe-bench/apps/frappe/frappe/test_runner.py", line 224, in make_test_records
    make_test_records_for_doctype(options, verbose, force)
  File "/home/britlog/frappe-bench/apps/frappe/frappe/test_runner.py", line 269, in make_test_records_for_doctype
    frappe.local.test_objects[doctype] += make_test_objects(doctype, test_module.test_records, verbose, force)
  File "/home/britlog/frappe-bench/apps/frappe/frappe/test_runner.py", line 311, in make_test_objects
    d.insert()
  File "/home/britlog/frappe-bench/apps/frappe/frappe/model/document.py", line 193, in insert
    self._validate()
  File "/home/britlog/frappe-bench/apps/frappe/frappe/model/document.py", line 400, in _validate
    self._validate_links()
  File "/home/britlog/frappe-bench/apps/frappe/frappe/model/document.py", line 625, in _validate_links
    invalid_links, cancelled_links = self.get_invalid_links()
  File "/home/britlog/frappe-bench/apps/frappe/frappe/model/base_document.py", line 496, in get_invalid_links
    setattr(self, df.fieldname, values.name)
AttributeError: 'NoneType' object has no attribute 'name'
4

@britlog,

It seems like the data related issue, you are getting the values as None which is causing the error.

Please try to debug the method get_invalid_links in base_document.py

5

@britlog best to run tests on a separate (fresh) site