Bench stops when I use 'from * import *'

Yomi · November 2, 2016, 8:07am

Hello, I am making a customization to a page, trying to include the attachments in an amended sales/purchase order. The feature is successfully implemented by editing documents.py accordingly. However when I use > from frappe.desk.form.load import get_attachments Bench stops and I get this error. The same error does not occur and everything works fine if I put the get_attachments function explicitly in script. I think it is a better approach to import than rewrite the function so I am looking for a fix for this.

Any help would be appreciated. Thanks.
@neilLasrado

shreyasp · November 2, 2016, 1:02pm

Hello Yomi,

It seems you are trying to access the redis localhost:11000 which is already used by the bench for redis_cache so in case you are trying to access which causes bench to shutdown.

Yomi · November 3, 2016, 4:04am

Hi Shreyasp,

I access my site normally with my ipaddresss, which is not localhost. I disabled the 127.0.0.1 bind address and I have my designated ipadress that I use to access my site.

Also, this error occurs only if I have that particular from…import in my script. If I comment out that particular from import, bench is up and running and there are other import statements in the file as well that work without any issues.

shreyasp · November 3, 2016, 9:14am

@Yomi

Can you tell me what specific import statement in your python file leads to stop the bench?

Yomi · November 3, 2016, 9:15am

from frappe.desk.form.load import getattachments

shreyasp · November 3, 2016, 9:20am

@Yomi

github.com

frappe/frappe/blob/develop/frappe/desk/form/load.py#L113


      
          	]
          
          
	docinfo = frappe._dict(user_info={})
          
          
	add_comments(doc, docinfo)
          
          
	docinfo.update(
          		{
          			"doctype": doc.doctype,
          			"name": doc.name,
          			"attachments": get_attachments(doc.doctype, doc.name),
          			"communications": communications_except_auto_messages,
          			"automated_messages": automated_messages,
          			"total_comments": len(json.loads(doc.get("_comments") or "[]")),
          			"versions": get_versions(doc),
          			"assignments": get_assignments(doc.doctype, doc.name),
          			"permissions": get_doc_permissions(doc),
          			"shared": frappe.share.get_users(doc.doctype, doc.name),
          			"views": get_view_logs(doc.doctype, doc.name),
          			"energy_point_logs": get_point_logs(doc.doctype, doc.name),
          			"additional_timeline_content": get_additional_timeline_content(doc.doctype, doc.name),

As per the file there is function definition for get_attachments(…) while you seem reference getattachments.

Yomi · November 3, 2016, 9:53am

Sorry that seems to be a typo from me in this post. I use get_attachments. Here’s a screenshot of that portion of the script, taken directly from my documents.py. The second to the last one is the one that stops bench.

Yomi · November 8, 2016, 11:36am

This issue is fixed. It was resolved by placing the > from … import statement within the new function defined in the script.