Bench update does not update nginx config. Should it?

1

I was having big problems with PDF reports in emails with no css or images attached.

The problem is fixed by adding the site to site_config.json, as discussed here.

https://discuss.frappe.io/t/pdf-is-not-aligned/5376/8

My question is, does it make sense to have bench update check the nginx.conf? It would probably save people a lot of grief when generating pdf files.

2

@PapaSmERP thanks for the feedback.

@shreyasp is working on updates to bench. Let me ask him.

3

Thanks. More clearly stated, my question is, can bench update look at the nginx port configuration, then write a line to the site_config.json file for each site if the port in use is not the default one? Maybe not possible due to multitenancy accommodations?