[Bot] [Discussion] [PR #13036] feat: Tab Break fieldtype

1

Testing Site URL: https://gh-imp-2021-00620.castlecraft.co.in

Pull Request URL: https://github.com/frappe/frappe/pull/13036
Pull Request Title: feat: Tab Break fieldtype
Pull Request Description:

https://user-images.githubusercontent.com/19775888/118644959-f4670a80-b7fb-11eb-81b1-93f7c6e10ee0.mov

Credentials

username: jordan40@brennan.com
password: 0398e7611a

2

I tried out the feature (e.g. on doctype user). It looks nice and is very handy.
However when I want to customize an existing doctype and change e.g. a section break to a tab break, I can’t find this data type in the available options. Does it have a different name or am I missing something?

Screenshot_20210724-062819_Chrome
Screenshot_20210724-062819_Chrome1080×2044 185 KB

3

Is under the Signature Option.

4

I could not find the option as well in Field Type dropdown.
Would be helpful if the contributor can write a few lines on what the Contribution is about and steps to test.

Thanks

5

I am not able to select signature. Also not very intuitive naming if the PR is called Tab Break. Maybe rename field?

Screenshot_20210724-115537_Chrome
Screenshot_20210724-115537_Chrome1080×534 85.5 KB

6

Try to create a new field and select the fieldtype as Tab Break(last option in field type list).

image
image999×39 2.88 KB

7

Yep I too tried I didn’t get any difference in UI.
I’m Requesting the Author to give a detail descriptions.

Thanks

8

Sorry. I guess I misunderstood your message? Signature is a different field type. Tab Break is not available for me.

9

created a new doctype as below

image
image1292×729 49.1 KB

new doc

image
image1333×609 34.6 KB

not working as expected.

10

It works if we add section break field just after tab break

image
image1920×1080 227 KB

2 Likes
11

please check my comment in github pull request.

12

Congratulation to this discussion members, its being merged , let us evaluate it to making it perfect, i found not working and created issue