Cannot Edit Cells in a List's Report View Any Longer

ERPNext
,
1

Hello

After the upgrade from ERPNext v15.49.3 to v15.50.1, Frappe to v15.55.0, cells in a list’s report view cannot be edited any longer.

Previously, after double-clicking, one was able to edit at least simple values (strings, numbers, dates), but now everything is just read-only.

Would be very nice to have that feature back again.

Thanks for looking into this!

2

Hi,

After upgrading to ERPNext 15.51.0 and Frappe 15.55.1 the feature seems to be working here.

4

Thanks much for quick, promising reply!

Upgraded docker-based development environment with the versions you mention but unfortunately issue persists :slightly_frowning_face:

5

For what it’s worth, I tried in a v16.0.0-dev Docker setup , I don’t see the problem in that with demo data.

6

Thanks much for taking the time and letting me know. Cannot see any change here though that might have caused this new behavior. Will debug and hopefully fix it.

7

The issue is also on our Frappe Cloud instance, ERPNext v15.50.1, Frappe v15.55.0.

But I think I found the bug. Seems to be in frappe-bench/apps/frappe/frappe/public/js/frappe/views/reports/report_view.js, line 720, function is_editable(df, data).

In ERPNext v15.51.0, Frappe v15.55.1, it reads

	is_editable(df, data) {
		return (
			df &&
			frappe.model.can_write(this.doctype) &&
			// not a submitted doc or field is allowed to edit after submit
			(data.docstatus !== 1 || df.allow_on_submit) &&
			// not a cancelled doc
			data.docstatus !== 2 &&
			!df.read_only &&
			!df.is_virtual &&
			!df.hidden &&
			// not a standard field i.e., owner, modified_by, etc.
			frappe.model.is_non_std_field(df.fieldname) &&
			// don't check read_only_depends_on if there's child table fields
			!this.meta.fields.some((df) => df.fieldtype === "Table") &&
			df.read_only_depends_on &&
			!this.evaluate_read_only_depends_on(df.read_only_depends_on, data)
		);
	}

But the last three subconditions seem not to be according to intention. Should probably read

	is_editable(df, data) {
		return (
			df &&
			frappe.model.can_write(this.doctype) &&
			// not a submitted doc or field is allowed to edit after submit
			(data.docstatus !== 1 || df.allow_on_submit) &&
			// not a cancelled doc
			data.docstatus !== 2 &&
			!df.read_only &&
			!df.is_virtual &&
			!df.hidden &&
			// not a standard field i.e., owner, modified_by, etc.
			frappe.model.is_non_std_field(df.fieldname) &&
			// don't check read_only_depends_on if there's child table fields
			(
				this.meta.fields.some((df) => df.fieldtype === "Table") ||
				!df.read_only_depends_on ||
				!this.evaluate_read_only_depends_on(df.read_only_depends_on, data)
			)
		);
	}

At least with these changes report list view cell editing now works again as before :slight_smile: