Cannot proceed with update

NeisSenni · June 8, 2017, 7:20am

Can someone help to resolve this error. Bench v4.0.1 Frappe v8.0.65 and ERPNext v8.0.46.
$git diff / $ git stash also shows nothing. Tried git reset --hard but can not proceed with update.

tundebabzy · June 8, 2017, 7:35am

Hi. How come your develop branch for frappe is 1 commit ahead of upstream/develop?

NeisSenni · June 8, 2017, 7:55am

Hi @tundebabzy, found this file difference so did the commit.

Putting git log, may be it is useful.

tundebabzy · June 8, 2017, 9:26am

OK.
Please discard your commit from the tree and then bench update again. It’s your commit that is breaking the update. Meanwhile, always commit all changes to a local branch

NeisSenni · June 8, 2017, 10:34am

@tundebabzy, how do you know that the commits are done at remote branch? I don’t think I have access to remote branch.

tundebabzy · June 8, 2017, 11:37am

You can commit but cannot push.

NeisSenni · June 8, 2017, 12:24pm

@tundebabzy, at start the error was coming so did git reset --hard and found this file so did the commit. The commit is reverted but no change in the error. If you want me to run specific commands then please tell me.

tundebabzy · June 8, 2017, 1:03pm

Hello @NeisSenni
Let’s try this
run:
git log

Next, copy out the hash of the commit before yours. From an earlier screenshot, it’s the one by Ayush Shukla (e2de37b). Then run:
git reset <copied out hash>

Try to update again and let’s see if that works. Sorry for the hassle though.

NeisSenni · June 8, 2017, 1:17pm

@tundebabzy, I just did reset (git reset --hard upstream) so now it is at Ayush Shukla’s commit but still can’t update.

I am using Antix Linux (Debian 7), are there any check specific to OS that restricts the update.

johnskywalker · June 11, 2017, 11:35am

I think you can just bench update --reset it

NeisSenni · June 12, 2017, 3:43am

@johnskywalker, have run bench update --reset and then bench update. Bench update still giving error “Cannot proceed with update”.

fahimalizain · June 12, 2017, 6:32am

try this in the root folder ? (upstream should be GitHub - frappe/frappe: Low code web framework for real world applications, in Python and Javascript by default)

git reset --hard upstream/develop

NeisSenni · June 12, 2017, 8:14am

@fahimalizain tried with “git reset --hard upstream/develop” , still cannot proceed with update.

fahimalizain · June 12, 2017, 8:38am

Check if you have any files untracked in frappe, if any delete it

git status

Are you sure that frappe is the app that causing the issue in the error thats given now ? (maybe modified erpnext or any other app could cause this too)

Please post bench update error output again if all else fails.
Thank you

NeisSenni · June 12, 2017, 11:42am

@fahimalizain , I have two apps frappe and erpnext. “git status” command have run at both the apps. Please find the output here.

fahimalizain · June 12, 2017, 11:58am

Thats a bug from bench.
It expects the text nothing to commit, working directory clean, instead your output is nothing to commit (working directory clean), which also should be allowed.

github.com

frappe/bench/blob/master/bench/app.py#L145


      
          	logger.info('Getting app {0}'.format(repo_name))
          	exec_cmd("git clone {git_url} {branch} {shallow_clone} --origin upstream".format(
          		git_url=git_url,
          		shallow_clone=shallow_clone,
          		branch=branch),
          		cwd=os.path.join(bench_path, 'apps'))
          
          
	app_name = get_app_name(bench_path, repo_name)
          	install_app(app=app_name, bench_path=bench_path, verbose=verbose, skip_assets=skip_assets)
          
          

          
def get_app_name(bench_path, repo_name):
          	# retrieves app name from setup.py
          	app_path = os.path.join(bench_path, 'apps', repo_name, 'setup.py')
          	with open(app_path, 'rb') as f:
          		app_name = re.search(r'name\s*=\s*[\'"](.*)[\'"]', f.read().decode('utf-8')).group(1)
          		if repo_name != app_name:
          			apps_path = os.path.join(os.path.abspath(bench_path), 'apps')
          			os.rename(os.path.join(apps_path, repo_name), os.path.join(apps_path, app_name))
          		return app_name

EDIT: I am not so sure if its safe to pull from the app dir itself.

Thank you.

fahimalizain · June 12, 2017, 12:29pm

Are you running Antix Linux ?
saw your post here regarding that: ERPNext setup on Antix Linux - #6 by NeisSenni

I guess git outputs are different in that ?

NeisSenni · June 12, 2017, 2:09pm

@fahimalizain, I have update the file app.py but its still showing the same message while doing bench update. The cause of the message seems quite correct. May be have to do something else after updating file app.py to take it into action.

Yes, I am using Antix Linux and have also mentioned it above.

Overall its fine. Thanks @fahimalizain, @johnskywalker and @tundebabzy for all your efforts.

fahimalizain · June 12, 2017, 2:17pm

Try changing the app.py line 145 to the following and check again ?

if not re.search(r'nothing to commit(, working (directory|tree) clean| \(working (directory|tree) clean\))', out):

Also confirm that the edits you make in bench .py are actually coming in action by using some test print statements.

NeisSenni · June 13, 2017, 3:56pm

@fahimalizain, copy and pasted the line you have suggested in app.py file. Now it is working fine. Thanks again!