Cannot remove Communication Item tag which contains spaces

aleksas · February 5, 2018, 12:55pm

When tagging communication items, everything is fine (tagging, removing tag) unless the tag contains space.

If tag contains space, clicking x on the tag doesn’t do anything.

ENV:

ERPNext: v10.0.19 (master)
Frappe Framework: v10.0.20 (master)

GitHub Issue

clarkej · February 5, 2018, 4:36pm

Thanks for reporting this @aleksas

github.com

frappe/frappe/blob/develop/frappe/public/js/frappe/ui/tag_editor.js

frappe.ui.TagEditor = class TagEditor {
	constructor(opts) {
		/* docs:
		Arguments

		- parent
		- user_tags
		- doctype
		- docname
		*/
		$.extend(this, opts);

		this.setup_tags();

		if (!this.user_tags) {
			this.user_tags = "";
		}
		this.initialized = true;
		this.refresh(this.user_tags);
	}

This file has been truncated. show original

github.com

frappe/frappe/blob/23d073adb797970442695c668e35d51265548b00/frappe/desk/tags.py

# Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
# MIT License. See license.txt

from __future__ import unicode_literals, print_function
import json
"""
Server side functions for tagging.

- Tags can be added to any record (doctype, name) in the system.
- Items are filtered by tags
- Top tags are shown in the sidebar (?)
- Tags are also identified by the tag_fields property of the DocType

Discussion:

Tags are shown in the docbrowser and ideally where-ever items are searched.
There should also be statistics available for tags (like top tags etc)


Design:

This file has been truncated. show original

clarkej · March 22, 2018, 4:56pm

This is to confirm you fix thanks @aleksas

krnkris · March 24, 2018, 2:55pm

We do have some more problem with tags:

https://github.com/frappe/frappe/issues/4875

Anyone else face this issue?