Cant delete email inbox icon from desktop v. 8-beta

JoEz · March 16, 2017, 9:16am

Hi there, any hint on how to remove icon from desktop?

I’ve deleted all Email Inbox icon from icon list but it wont disappear and any user can see all communication like the System Manager.

Thx

JoEz · March 16, 2017, 10:49am

Ok, i got the point. For some reason Email Inbox icon is hardcoded in the desktop.js file:

github.com

frappe/frappe/blob/d45e5a6154d428ae2983021ccee18eb75b7f0c12/frappe/core/page/desktop/desktop.js#L48


      
          			_label: __('Explore'),
          			_id: 'Explore',
          			_doctype: '',
          			icon: 'octicon octicon-telescope',
          			color: '#7578f6',
          			link: 'modules'
          		};
          		explore_icon.app_icon = frappe.ui.app_icon.get_html(explore_icon);
          		all_icons.push(explore_icon);
          
          
		var inbox_icon = {
          			module_name: 'Communication',
          			label: 'Email Inbox',
          			_label: __('Email Inbox'),
          			_id: 'Email Inbox',
          			_doctype: 'Communication',
          			icon: 'fa fa-envelope-o',
          			color: '#589494',
          			link: 'List/Communication/Inbox'
          		}
          		inbox_icon.app_icon = frappe.ui.app_icon.get_html(inbox_icon)

What’s the reason for that?

Any hint on how to remove it so that changes will not be lost when running bench update?

Thx

makarand_b · March 16, 2017, 1:07pm

@JoEz,

added a condition now Email Inbox desktop will show up only if the user has configured the email inbox.

https://github.com/frappe/frappe/pull/2884

Thanks,
Makarand

JoEz · March 16, 2017, 1:36pm

@makarand_b great, thx!