Can't delete Task from the Project

Amalendu · June 10, 2016, 2:50pm

Hai

My Project contains Tasks. If i do delete all tasks and save the form once, it again shows all tasks. If i delete only one task and save the document, then it updates correctly. The problem is when i try to remove all tasks at a stretch. OR if i have only one task and delete, it again gets saved!!!
I can’t identify where the code twists!!!
Anyone can help me please. I want to solve this urgently.

kolate_sambhaji · June 11, 2016, 6:22am

@Amalendu

Can you try to delete Task from Task?
May be your task is linked with another doctype.
Please note, if task is linked with another doctype, then you need to delete linked doctype first.

also post bug on Issues · frappe/erpnext · GitHub

kolate_sambhaji · June 11, 2016, 7:11am

@Amalendu

The issue is, onload is called before validate.
When we delete task and save form, sync_task is called to delete task, but before actual deletion onload adds deleted task.

github.com

frappe/erpnext/blob/develop/erpnext/projects/doctype/project/project.py#L76


      
          				tmp_task_details.append(template_task_details)
          				task = self.create_task_from_template(template_task_details)
          				project_tasks.append(task)
          			self.dependency_mapping(tmp_task_details, project_tasks)
          
          
	def create_task_from_template(self, task_details):
          		return frappe.get_doc(
          			dict(
          				doctype="Task",
          				subject=task_details.subject,
          				project=self.name,
          				status="Open",
          				exp_start_date=self.calculate_start_date(task_details),
          				exp_end_date=self.calculate_end_date(task_details),
          				description=task_details.description,
          				task_weight=task_details.task_weight,
          				type=task_details.type,
          				issue=task_details.issue,
          				is_group=task_details.is_group,
          				color=task_details.color,
          			)

github.com

frappe/erpnext/blob/develop/erpnext/projects/doctype/project/project.py#L18


      
          from frappe.desk.reportview import get_match_cond
          from frappe.model.document import Document
          from frappe.utils import add_days, flt, get_datetime, get_time, get_url, nowtime, today
          
          
from erpnext import get_default_company
          from erpnext.controllers.queries import get_filters_cond
          from erpnext.setup.doctype.holiday_list.holiday_list import is_holiday
          
          

          
class Project(Document):
          	def onload(self):
          		self.set_onload(
          			"activity_summary",
          			frappe.db.sql(
          				"""select activity_type,
          			sum(hours) as total_hours
          			from `tabTimesheet Detail` where project=%s and docstatus < 2 group by activity_type
          			order by total_hours desc""",
          				self.name,
          				as_dict=True,
          			),

Amalendu · June 11, 2016, 5:02pm

@kolate_sambhaji

Yes, I can delete tasks from ‘Tasks’ list. Thats good. But what can I do to delete it from ‘Project’?

kolate_sambhaji · June 13, 2016, 7:26am

@Amalendu
I have checked and its a bug.
You can create new issue on github

jaichavan · January 20, 2019, 4:03pm

Hello, @Amalendu thanks for reaching out! Tried to replicate in the latest version [ ERPNext: v11.0.3-beta.34 () (staging) ] but couldn’t, it’s working as expected - Deletion can be done from Project itself! Attaching GIF for your reference:

delete-task-from-project