Can't Save Existing Asset

santhida · May 23, 2020, 5:09am

I couldn’t save existing asset in current version

I got " Gross Purchase Amount should be equal to purchase amount of one single Asset.
Please do not book expense of multiple assets against one single Asset." message

clarkej · May 24, 2020, 2:10pm

Presumably this is a failed validation - whether it’s valid and reasonable is the question.

Searches for the validation message turned up no solid leads, a traceback would help identify where in the code this occurs.

This has seen lots of changes in the last several months History for erpnext/assets/report/fixed_asset_register/fixed_asset_register.py - frappe/erpnext · GitHub

What version erpenxt and frappe is this?

santhida · May 25, 2020, 2:30am

ERPNext v12.9.0 and Frappe v12.6.0
before upgrade, system work properly

Shyam_Sundar · May 26, 2020, 7:32am

I am also facing the same issue. Can’t save existing asset. The same message is coming. It was working before the new update.

waiminn · May 26, 2020, 8:10am

Here is the validation code that cause this issue:

github.com

frappe/erpnext/blob/a7f42f72565ef1e47629101cabb0ad5e57c62d71/erpnext/assets/doctype/asset/asset.py#L129


      
          			return
          
          
		docname = self.purchase_receipt or self.purchase_invoice
          		if docname:
          			doctype = 'Purchase Receipt' if self.purchase_receipt else 'Purchase Invoice'
          			date = frappe.db.get_value(doctype, docname, 'posting_date')
          
          
		if self.available_for_use_date and getdate(self.available_for_use_date) < getdate(self.purchase_date):
          			frappe.throw(_("Available-for-use Date should be after purchase date"))
          
          
	def validate_gross_and_purchase_amount(self):
          		if self.is_existing_asset: return
          		
          		if self.gross_purchase_amount and self.gross_purchase_amount != self.purchase_receipt_amount:
          			frappe.throw(_("Gross Purchase Amount should be {} to purchase amount of one single Asset. {}\
          				Please do not book expense of multiple assets against one single Asset.")
          				.format(frappe.bold("equal"), "<br>"), title=_("Invalid Gross Purchase Amount"))
          
          
	def cancel_auto_gen_movement(self):
          		movements = frappe.db.sql(
          			"""SELECT asm.name, asm.docstatus

There is no need to check Gross Purchase Amount and Purchase Receipt Amount If Is Existing Asset is checked on Asset creation.

Should check Is Existing Asset value before above validation.

My workaround for this issue is:

Customization > Custom Script > New

In DocType field, choose Asset

In Script field, just put code below and save:

frappe.ui.form.on('Asset', {
	validate(frm) {
	    if (frm.doc.is_existing_asset) {
	        frm.doc.purchase_receipt_amount = frm.doc.gross_purchase_amount;
	    }
	}
})

Then reload the desk and try again saving Existing Asset.

Hope that Team will fix this issue very soon.

waiminn · June 3, 2020, 8:18pm

Finally fixed in 12.9.4 release.

Thank you Team.