Creating Journal Entry using REST API, "title" field is ignored

Ardan · September 24, 2015, 3:46pm

Hi, using the following API call, I can create a Journal Entry, however the “title” field is ignored and the Title is populated with the first ‘Account’ entry “Accruals and Deferred Income - TC”

http://localhost/api/resource/Journal%20Entry?data={“title”:“Daily Sales Posting 1st Sep 2015”,“posting_date”:“2015-09-01”,“doctype”:“Journal Entry”, “naming_series”:“JV-”, “voucher_type”:“Journal Entry”, “accounts”:[{“is_advance”:“No”,“cost_center”:“Main - TC”,“account”:“Accruals and Deferred Income - TC”,“doctype”:“Journal Entry Account”,“debit”:50.0,“docstatus”:1},{“is_advance”:“No”,“cost_center”:“Main - TC”,“account”:“Cash on hand - TC”,“doctype”:“Journal Entry Account”,“credit”:50.0,“docstatus”:1}], “owner":"ardan@corebpm.com”, “user_remark”:“Daily Sales 1st Sep 2015”, “remark”:“Daily Sales Posting 1st Sep 2015”, “docstatus”:1}

Can the “title” field be entered this way? Thanks

rmehta · September 25, 2015, 9:43am

github.com

frappe/erpnext/blob/develop/erpnext/accounts/doctype/journal_entry/journal_entry.py#L48


      
          		if self.voucher_type == "Opening Entry":
          			self.is_opening = "Yes"
          
          
		if not self.is_opening:
          			self.is_opening = "No"
          
          
		self.clearance_date = None
          
          
		self.validate_party()
          		self.validate_entries_for_advance()
          		self.validate_multi_currency()
          		self.set_amounts_in_company_currency()
          		self.validate_debit_credit_amount()
          
          
		# Do not validate while importing via data import
          		if not frappe.flags.in_import:
          			self.validate_total_debit_and_credit()
          
          
		if not frappe.flags.is_reverse_depr_entry:
          			self.validate_against_jv()
          			self.validate_stock_accounts()

We need to remove / fix this.

Ardan · October 9, 2015, 2:13am

Hi @rmehta, is there any progress on this fix as I am finalising some API interfacing and need to be able to set the Title for Journal Entries. Should I put an entry in Github?
Many thanks

rmehta · October 12, 2015, 11:30am

Fixed: [fix] set title in Journal Entry only if not set by rmehta · Pull Request #4158 · frappe/erpnext · GitHub

But please feel free to send PR if you think its reasonable.

Ardan · October 12, 2015, 3:44pm

Hi @rmehta, tested the changes and it works as expected. Many thanks for the fix

superlack · October 13, 2015, 5:53am

Has the title field ever worked correctly for overriding the auto naming of Projects?

Ardan · October 13, 2015, 6:55am

Hi @superlack,before the fix I was able to use the API’s to ‘update’ the title field as expected. Previously if I created a Journal Entry via API, it would not allow me to write the “title” field on creation so all I could do is to then follow up with a PUT request to update the title to what I required. This problem was only with Journal Entries. Now I can write to the Title field on creation - thus effecively overriding the auto-naming in the Title field

superlack · October 15, 2015, 2:47am

Ah, I see what you mean now. I thought this was to do with adding a custom “title” field to override autonaming.

Great to know about this anyway!