Custom Script being override by POS Profile

alan · May 13, 2018, 9:25am

For custom script, by right it should override everything else.

However, I realised some error as following

I tried to pull the correct Cost Center , Letter Head and Naming Series if the users select the Delivery Warehouse.
Everything works fine if there’s no POS Profile Involve.
The POS Profile will OVERRIDE the custom script if there’s default pos profile being set under the POS Profile List.
This only happened when Convert the Sales Order to Sales Invoice, if directly Created Sales Invoice, it’s ok.

I’m wondering where went wrong on this part, To Create Invoice from Sales Order and Create Invoice works differently for the same script.

Anyone have any idea ?

rohit_w · May 13, 2018, 10:43am

Hi @alan

If you’re making the invoice with Include Payment (POS) then system always pulls the data from the respective POS Profile. If you want to change this behaviour you have to make changes in the core code.

github.com

frappe/erpnext/blob/develop/erpnext/accounts/doctype/sales_invoice/sales_invoice.py#L339


      
          			)
          			pos_closing_entry = frappe.get_all(
          				"POS Invoice Merge Log", filters={invoice_or_credit_note: self.name}, pluck="pos_closing_entry"
          			)
          			if pos_closing_entry and pos_closing_entry[0]:
          				msg = _("To cancel a {} you need to cancel the POS Closing Entry {}.").format(
          					frappe.bold("Consolidated Sales Invoice"),
          					get_link_to_form("POS Closing Entry", pos_closing_entry[0]),
          				)
          				frappe.throw(msg, title=_("Not Allowed"))
          
          
	def before_cancel(self):
          		self.check_if_consolidated_invoice()
          
          
		super(SalesInvoice, self).before_cancel()
          		self.update_time_sheet(None)
          
          
	def on_cancel(self):
          		check_if_return_invoice_linked_with_payment_entry(self)
          
          
		super(SalesInvoice, self).on_cancel()

You need to remove True from the method get_pos_profile_item_details

alan · May 13, 2018, 11:44pm

The weird things is it only happened as following

If direct from Sales Invoice, Include POS, the custom script works perfectly.
If Create from Sales Order to Sales Invoice, it have problems.
For (2) also, if I remove all users from POS Profile, it still pull from POS. But If I add one dummy user, other users will works correctly according to the custom script.

So I’m wondering modify this works. Kindly comment.

jof2jc · May 14, 2018, 12:13am

can you share your custom script?