Data import Tool & doc events

PyJumper · August 15, 2023, 12:49pm

Hello, data import tools does not trigger doc events which then not trigger webhooks as stated in this replay. we are looking for any solution because this feature is important to update our external ecommerce store product prices

the following github issue & PR could fix the problem but there is no activity on the PR

github.com/frappe/frappe

Webhook not firing when importing data with ERPNext import tool

opened 06:51AM - 12 Mar 23 UTC

closed 09:49AM - 15 Mar 23 UTC

KhaledBinAmir

wontfix

## Description of the issue Hey guys, I've noticed that the webhook feature in ERPNext doesn't seem to trigger any events when I use the import tool to add data. I've set up a webhook to fire on insert, update, and submit events, but it just doesn't seem to be working when I import data. I've tested this multiple times and it's not just me being dumb. It's a pretty frustrating issue because I rely on the webhook to keep my external system up-to-date with my ERPNext data. Can you guys take a look at this issue and get it sorted out? It would be awesome to have the webhook feature working consistently across all data entry methods. Let me know if you need more information from me. Cheers! ## Context information (for bug reports) **Output of `bench version`** ``` erpnext 14.18.2 frappe 14.27.0 hrms 14.1.0 payments 0.0.1 waba_integration 0.0.1 ```

github.com/frappe/frappe

feat: add checkbox option to trigger webhooks during import

frappe:develop ← KhaledBinAmir:webhook-on-import

opened 09:45AM - 29 Mar 23 UTC

KhaledBinAmir

+13 -1

>Caution: Newbie Here **Description** This pull request adds a new feature t…o the import tool in ERPNext that allows users to choose whether or not to trigger webhooks when documents are imported using the tool. Currently, there is no way to fire webhooks when documents are inserted by the import tool, which is a limitation for some use cases. To solve this issue, I have added a checkbox in the import UI labeled "Don't Trigger Webhooks", which is checked by default. If a user wants to trigger webhooks during the import process, they can simply uncheck this checkbox before importing the files. I have tested this feature locally, and it works as expected. This change modifies a total of 4 files in the ERPNext codebase. **Purpose** The purpose of this change is to provide more flexibility to users who need to trigger webhooks when importing documents into ERPNext using the import tool. With this new feature, users can choose to trigger webhooks only when they need to, rather than being limited by the current behavior of the import tool. Screenshots ![image](https://user-images.githubusercontent.com/30042185/228494564-bbb59ca8-0388-40fb-b3ec-570ce99ff131.png)

PyJumper · August 17, 2023, 12:42pm

hello, for now i solved this issue by adding simple CSV import feature to my extenstion, if someone need it:

CA_B.C_Chechani · August 18, 2023, 1:23am

I installed it to understand CSV import may be handy from UI, so whether it will be similar to the command for CSV import or what else pros and cons, whether it supports only update records?

PyJumper · August 18, 2023, 5:50am

Hello, here are some pros and cons which I will also note in the next update:

pros:

update records using python instead of SQL which means server scripts, webhooks, doc events will work

cons:

using client.py bulk update, does not use background job which can slow website for huge data records especially if that doc has extra hooks, server scripts, webhooks etc
do not support child tables data
column name representing doc name must be (ID), will try to fix in the next update

finally, this may not be the proper way to update csv records, this was a temporal solution for our client to update their Item Price data, But we are looking for other better solutions like custom data import app which support doc_events, maybe customized data import tool version