Date field rise an error if Set Only Once is enabled and doc trying to be saved multiple time

JoEz · October 26, 2016, 10:23pm

Hi there,

i’ve set few field with Set Only Once set to 1; one of this field is a Date type named Data. See pic:

When i try save multiple times, an error is raised: Value cannot be changed for Data.

That’s the only field raising the error; it’s kind of strange because field is read only and Date value is not changed …

what i’m doing wrong?

Thx in advance

Pawan · October 27, 2016, 2:08am

Do you have any script that is trying to modify the date value?

JoEz · October 27, 2016, 6:35am

Nope …no custom script

JoEz · October 27, 2016, 7:13am

@Pawan could be the validator checking date and time instead of date only?

JoEz · October 27, 2016, 9:40am

Any news on this? is that a bug?

JoEz · October 27, 2016, 3:26pm

@Pawan could u please have a look at:

github.com

frappe/frappe/blob/develop/frappe/model/base_document.py#L507


      
          				"""INSERT INTO `tab{doctype}` ({columns})
          					VALUES ({values}) {conflict_handler}""".format(
          					doctype=self.doctype,
          					columns=", ".join("`" + c + "`" for c in columns),
          					values=", ".join(["%s"] * len(columns)),
          					conflict_handler=conflict_handler,
          				),
          				list(d.values()),
          			)
          		except Exception as e:
          			if frappe.db.is_primary_key_violation(e):
          				if self.meta.autoname == "hash":
          					# hash collision? try again
          					frappe.flags.retry_count = (frappe.flags.retry_count or 0) + 1
          					if frappe.flags.retry_count > 5 and not frappe.flags.in_test:
          						raise
          					self.name = None
          					self.db_insert()
          					return
          
          
				if not ignore_if_duplicate:

it seems to be failing testing dates even if date are the equals; i have it working by changing to:

if self.get(fieldname) != str(values.get(fieldname)):

Actually i’m not sure if it work for every types …btw can you please have a look?

Edit: opened an issue on github:

https://github.com/frappe/frappe/issues/2224