Does ERPNext support Python 3.8?

Mohd_Rizal_sharif · March 26, 2020, 1:13pm

hi i`m planing upgrede my server to version 12
does erpnext support python 3.8?

thanks.

revant_one · March 26, 2020, 1:38pm

I have python 3.8 default in my system. (Arch Linux)

It’s working as expected. Just some warning messages

To be specific

../apps/erpnext/erpnext/accounts/doctype/share_transfer/share_transfer.py:172: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  shareholders = [shareholder for shareholder in shareholders if self.get(shareholder) is not '']

medo2001 · August 6, 2020, 3:05pm

how fix this

kennethsequeira · August 6, 2020, 3:51pm

The warning will only occur with version 12 due to this code:

github.com

frappe/erpnext/blob/80c016a1ada3b4af9d1df47f491d4a3d679d91dc/erpnext/accounts/doctype/share_transfer/share_transfer.py#L172


      
          				return 'Complete' # absolute truth!
          			elif entry.from_no <= self.from_no <= self.to_no:
          				return 'Partial'
          			elif entry.from_no <= self.to_no <= entry.to_no:
          				return 'Partial'
          
          
		return 'Outside'
          
          
	def folio_no_validation(self):
          		shareholders = ['from_shareholder', 'to_shareholder']
          		shareholders = [shareholder for shareholder in shareholders if self.get(shareholder) is not '']
          		for shareholder in shareholders:
          			doc = self.get_shareholder_doc(self.get(shareholder))
          			if doc.company != self.company:
          				frappe.throw(_('The shareholder does not belong to this company'))
          			if not doc.folio_no:
          				doc.folio_no = self.from_folio_no \
          					if (shareholder == 'from_shareholder') else self.to_folio_no
          				doc.save()
          			else:
          				if doc.folio_no and doc.folio_no != (self.from_folio_no if (shareholder == 'from_shareholder') else self.to_folio_no):

This is due to changes in Python 3.8:

https://bugs.python.org/issue34850

Since the same code is not running in version 13 or develop, the warning shouldn’t occur further.