Dropbox email message

froldan · August 23, 2017, 1:43pm

Hi everyone,
The subject and message of the email that is sent when the Dropbox backup (or another service) is done are hard coded and untranslatable.

github.com

frappe/frappe/blob/develop/frappe/integrations/doctype/dropbox_settings/dropbox_settings.py#L55


      
          @frappe.whitelist()
          def take_backup():
          	"""Enqueue longjob for taking backup to dropbox"""
          	enqueue(
          		"frappe.integrations.doctype.dropbox_settings.dropbox_settings.take_backup_to_dropbox",
          		queue="long",
          		timeout=1500,
          	)
          	frappe.msgprint(_("Queued for backup. It may take a few minutes to an hour."))
          
          

          
def take_backups_daily():
          	take_backups_if("Daily")
          
          

          
def take_backups_weekly():
          	take_backups_if("Weekly")
          
          

          
def take_backups_if(freq):
          	if frappe.db.get_single_value("Dropbox Settings", "backup_frequency") == freq:

I think it can be changed to use the translation tag or add to Dropbox Settings DocType a subject and message variable (both success and error) so the user can customize the email.

Any suggestions o possible solutions? the most important is the user receives the email in his own language.
I can contribute with a PR of course.

Thanks!

netchampfaris · August 23, 2017, 1:53pm

Yes, the email should be translated. Feel free to send a PR!

kolate_sambhaji · August 23, 2017, 1:59pm

There is one more issue/suggestion

Email message should contain default company or site name, so if anyone have more than one backup configured, one can easily understand which site backup are taken.

https://github.com/frappe/erpnext/issues/6913

froldan · August 23, 2017, 2:55pm

PR created!
https://github.com/frappe/frappe/pull/3986