Email Alerts for Workflows with Email Templates are no longer working!

wale · February 18, 2025, 10:23pm

Hi,

We observed that Email Alerts for Workflows with Email Templates are no longer working ! It shows the below error in the error logs:

builtins.TypeError: 'Document' object is not iterable

This has persisted for months now. We initially thought it was some issue from the template but later discovered its a bug

Does anyone have a workaround ?

Thanks

wale · February 18, 2025, 10:27pm

github.com/frappe/frappe

`object is not iterable` in Workflow "Next Action Email Template"

opened 05:09PM - 11 Dec 24 UTC

pReya

bug

## Description of the issue When a workflow for any DocType is triggering an …Email via the "Next Action Email Template", the Emails won't be sent out due to a `builtins.TypeError: 'SalesOrder' object is not iterable` error. ## Context information (for bug reports) **Output of `bench version`** ``` erpnext 15.41.1 frappe 15.47.2 hrms 15.35.0 ``` ## Steps to reproduce the issue 1. Create new workflow (and enable `Send Email Alert` option and set the Workflow to active) for DocType (e.g. `SalesOrder` or `LeaveApplication` are the two DocTypes we tested – possibly ALL Doctypes are affected) 2. Add at least two states to the workflow (e.g. pending and approved) 3. Edit the first state and assign a `Next Action Email Template` (it doesn't matter which template you pick – either any of the default ones will work or create a custom one yourself) 4. Add transition from first to second state 5. Trigger the workflow (e.g. by creating a `SalesOrder` or a `LeaveApplication`) 6. See Error in `Error Log List` titled `frappe.workflow.doctype.workflow_action.workflow_action.send_workflow_action_email` ### Observed result E-Mail is not sent out ### Expected result E-Mail should be sent ### Stacktrace / full error message ``` Traceback with variables (most recent call last): File "apps/frappe/frappe/utils/background_jobs.py", line 221, in execute_job retval = method(**kwargs) site = 'hr.mycompany.org' method = <function send_workflow_action_email at 0x7f42fed840e0> event = None job_name = 'frappe.workflow.doctype.workflow_action.workflow_action.send_workflow_action_email' kwargs = {'doc': <SalesOrder: SAL-ORD-2024-00005>, 'transitions': [{'allowed': 'Sales Master Manager', 'action': 'Approve', 'state': 'Pending', 'allow_self_approval': 1, 'next_state': 'Approved', 'condition': None}]} user = 'user2@anothercompany.de' is_async = True retry = 0 retval = None method_name = 'frappe.workflow.doctype.workflow_action.workflow_action.send_workflow_action_email' before_job_task = 'frappe.monitor.start' File "apps/frappe/frappe/workflow/doctype/workflow_action/workflow_action.py", line 382, in send_workflow_action_email common_args = get_common_email_args(doc) doc = <SalesOrder: SAL-ORD-2024-00005> transitions = [{'allowed': 'Sales Master Manager', 'action': 'Approve', 'state': 'Pending', 'allow_self_approval': 1, 'next_state': 'Approved', 'condition': None}] users_data = {'user2@anothercompany.de': {'possible_actions': [{'action_name': 'Approve', 'action_link': 'http://hr.mycompany.org/api/method/frappe.workflow.doctype.workflow_action.workflow_action.apply_action?doctype=Sales+Order&docname=SAL-ORD-2024-00005&action=Approve&current_state=Pending&user=user2%40anothercompany.de&last_modified=2024-12-11+17%3A51%3A55.650925&_signature=973ee385c2d5729394de0a3a30a10d22420fdac6fcfe0d6c5b1f63bba8ec128c40ec59c5b4a0dcbc955680aa86abdde594932fe65f033c27aaa6af21f81dbd67'}], 'email': 'user2@anothercompany.de'}, 'user1@anothercompany.de': {'possible_actions': [{'action_name': 'Approve', 'action_link': 'http://hr.mycompany.org/api/method/frappe.workflow.doctype.workflow_action.workflow_action.apply_action?doctype=Sales+Order&docname=SAL-ORD-2024-00005&action=Approve&current_state=Pending&user=user1%40anothercompany.de&last_modified=2024-12-11+17%3A51%3A55.650925&_signature=669df38551f55ffe2268665ccd18c3e84810b920e3a4c7341e0ef3534f42c8e63b7760e7721fc1f52f0d861a8477c2f60cc8248662d445e8513f90de6827a... File "apps/frappe/frappe/workflow/doctype/workflow_action/workflow_action.py", line 472, in get_common_email_args email_template = get_email_template_from_workflow(doc) doc = <SalesOrder: SAL-ORD-2024-00005> doctype = 'Sales Order' docname = 'SAL-ORD-2024-00005' File "apps/frappe/frappe/workflow/doctype/workflow_action/workflow_action.py", line 517, in get_email_template_from_workflow return get_email_template(template_name, doc) doc = <SalesOrder: SAL-ORD-2024-00005> workflow_name = 'test' doc_state = 'Pending' template_name = 'Leave Request' File "apps/frappe/frappe/utils/typing_validations.py", line 31, in wrapper return func(*args, **kwargs) args = ('Leave Request', <SalesOrder: SAL-ORD-2024-00005>) kwargs = {} apply_condition = <function whitelist.<locals>.innerfn.<locals>.<lambda> at 0x7f42fed7ee80> func = <function get_email_template at 0x7f42fed7ede0> File "apps/frappe/frappe/email/doctype/email_template/email_template.py", line 56, in get_email_template return email_template.get_formatted_email(doc) template_name = 'Leave Request' doc = <SalesOrder: SAL-ORD-2024-00005> email_template = <EmailTemplate: Leave Request> File "apps/frappe/frappe/email/doctype/email_template/email_template.py", line 46, in get_formatted_email "subject": self.get_formatted_subject(doc), self = <EmailTemplate: Leave Request> doc = <SalesOrder: SAL-ORD-2024-00005> File "apps/frappe/frappe/email/doctype/email_template/email_template.py", line 36, in get_formatted_subject return frappe.render_template(self.subject, doc) self = <EmailTemplate: Leave Request> doc = <SalesOrder: SAL-ORD-2024-00005> File "apps/frappe/frappe/utils/jinja.py", line 97, in render_template return get_jenv().from_string(template).render(context) template = 'Leave was requested' context = <SalesOrder: SAL-ORD-2024-00005> is_path = None safe_render = True TemplateError = <class 'jinja2.exceptions.TemplateError'> _ = <function _ at 0x7f43024619e0> get_traceback = <function get_traceback at 0x7f4301169800> throw = <function throw at 0x7f4301169da0> File "env/lib/python3.11/site-packages/jinja2/environment.py", line 1299, in render ctx = self.new_context(dict(*args, **kwargs)) self = <Template memory:7f42fd0f74d0> args = (<SalesOrder: SAL-ORD-2024-00005>,) kwargs = {} builtins.TypeError: 'SalesOrder' object is not iterable ``` ## Additional information Docker Self Hosted