ERPNext FinTS Connector (German Banks)

jHetzer · May 21, 2019, 6:16pm

I’m happy to announce an ERPNext FinTS Connector to synchronize bank statements with ERPNext.

Current status: Testing / Proof of Concept
Next steps: Full-fill ToDo list

If you are interested please test it out and leave a comment .
Contributions like ‘Issues’, ‘Feature Request’ and ‘Pull Requests’ are more the welcome.

vrms · May 22, 2019, 4:29am

is the limitation to “german banks” a technica onel (in the sense of german banks commonly using a certain system/api/… which non-german banks do not use)?

jHetzer · May 22, 2019, 5:56am

Yes, the app utilizes the API FinTS which is used by around 2000 German banks. But I think the process could be adapted for different API’s

github.com

jHetzer/erpnextfints/blob/104b09d77706658c9715c0f8da85dfbaa04e941a/erpnextfints/utils/import_payment.py#L35


      
                  if len(customer_by_iban) == 1:

                      party = customer_by_iban[0].name

              if not party and customer_name:

                  party = customer_name

              if not party:

                  party = self.default_customer

                  is_default = True

          

              return {"is_default": is_default, "party": party}

          

          def fints_import(self, fints_transaction):

              total_items = len(fints_transaction)

          

              for idx,t in enumerate(fints_transaction):

                  if t["status"].lower() == "c" and float(t["amount"]["amount"])  > 0:

                      amount = float(t["amount"]["amount"])

                      customerMapping = t["applicant_name"]

                      uniquestr = "{0},{1},{2},{3},{4}".format(

                          t["date"],

                          amount,

                          customerMapping,

European banks will be legislated to provide an online interface by mid 2019 but not restricted to one specific. (may only include web online banking)

vrms · May 22, 2019, 11:31am

great! thanks for clarifying

I guess that would be phase 2 then

jHetzer · May 24, 2019, 6:26pm

FinTS Import scheduler now available in development branch.

jHetzer · August 2, 2019, 5:30pm

FinTS Import scheduler and improvements on on master branch: Merge "develop" into "master" by jHetzer · Pull Request #4 · jHetzer/erpnextfints · GitHub

ERPNextFinTS now supports outgoing Payment Entries on the develop branch

rmeyer · August 2, 2019, 11:10pm

Great Work!

Can you tell us a bit more about your concept and the intended workflow?
Do you make use of the available Bank reconciliation?
What would be the setup process?

jHetzer · August 10, 2019, 8:09pm

This application is used to automatically import bank statements as “received” and “payed” Payment Entries with the original data from the bank. If possible the entries are matched and assigned to existing customers (by Name or IBAN) in ERPNext.
Afterwards this payment entries (status: Draft) can be linked to Sale/Purchase Invoices. For example with ERPNextSwiss “Match Payments” functionality.

Personally I do not grasp the purpose/simplification of the Bank Reconciliation functionality but I could be adapted from the Plaid Integration

Setup Process

Find your german bank FinTS information (e.g.)
Create a new “FinTS Login” in ERPNext with your information
Create a new “FinTS Schedule” (daily, weekly, monthly import) or do it manually with a new “FinTS Import”
Link the imported payment entries to your Sale/Purchase Invoices as you please

PS:
Each import creates a json file if it should be required to validate the import.

I hope i could answer your questions, feel free to ask more. Sorry for the late response I’m working on this on my free time.

jHetzer · September 11, 2019, 8:41pm

Currently the app is not working. Hopefully the FinTS Library maintainers are able to solve it:
https://github.com/raphaelm/python-fints/issues/72

More Information:

wojosc · November 29, 2019, 9:57am

Hello @jHetzer,

thank you for sharing this idea and your work. Has there been any progress since PSD2?

The guys from ERPNext are looking to make their software EU and Germany ready which will require your work.

Thank you
Wolfram

jHetzer · November 30, 2019, 2:41pm

Hey Wolfram

I’m happy to hear that ERPNext has interest in this work.
The maintainer of the FinTS Library are still working on the PSD2 Issue. Some banks are already working.
https://github.com/raphaelm/python-fints/pull/95
The ERPNextFinTS develop branch is using the PSD2 branch of python-fints which is working fine for e.g. Volksbank (https://hbci11.fiducia.de/cgi-bin/hbciservlet).

https://github.com/jHetzer/erpnextfints/commit/a924f05be94b7c1d403f4b8334cd96f349cd67f3
As soon as more information are available I will check how this can be implemented into the app.

Currently I’m working on a simple way to create customer bank accounts (doctype). During payment import this informations are used to assign the corresponding customer.
see https://github.com/jHetzer/erpnextfints/tree/bank_account_wizard.
(Screenshots will follow)

wojosc · December 1, 2019, 12:36pm

Hi,

thank you for sharing this progress. Volksbank and Kreissparkasse are the main two banks we are looking for at the moment.

Where would this thing go into core? I think this should go some where around “desk#modules/Integrations”.

Please let @Basawaraj_Savalagi know what you need to make this core ready.

As we are looking for KSK Integration for ourselves this would be very interesting for us and also connected to a bounty.

jHetzer · December 4, 2019, 11:04pm

Volksbank and Kreissparkasse are working in my lab. Unfortunately not without quirks but I’m excited what will result from this: PSD2 support by raphaelm · Pull Request #95 · raphaelm/python-fints · GitHub
I would suggest so. I think the plaid integration would function as a reference implementation. In regards to plaid integration I do not understand why it relies on the bank reconciliation functionality. Maybe someone can elaborate the benefit compared to importing payment entries
I’m still new to the ERPNext cosmos / Open Source collab. / git , maybe @Basawaraj_Savalagi can tell me what would be required to get core ready or what would the ERPNext Community need to adapt my app into the core

My code already starts hassling me and I’m about to rewrite certain parts. I think I could do better and improve it with my current python / javascript knowledge. I started the project as a newbie.

My self-imposed roadmap would look as following:

Watch and be support the FinTS Library progress
Complete the “Bank Account Wizard” page
Rewrite/Improve Code
Integrate unit-tests and maybe cypress-tests (personal studies required)

I’m working on this on my free time so I’m not able to propose a schedule, pardon me

itsdave · December 5, 2019, 1:51pm

Hi!
great work.
like wojosc, i would like the KSK integration too. In fact we planed to do an integration by ourselves, but had no time to do this yet.
If it helps, I would be in for a bounty, too.

jHetzer · December 6, 2019, 1:43am

I did some testing with the proposed PSD2 testing-script from the FinTS Library which worked for both VoBa and KSK after removing the if f.init_tan_response: part. Cross checking my code lead me to an unnecessary line.

My develop branch should work now for both banks. If someone is will to test please make sure to uninstall fints first with env/bin/pip uninstall fints from the virtualenv.
Check the link for the explantation:
https://github.com/jHetzer/erpnextfints/commit/5929e5e770a5b3d4ec6a26398b1e52bf8d817c14#commitcomment-36295468

wojosc · December 13, 2019, 6:36pm

Thanks! I will try that asap!

@joelios I’ll put this on the list. @jHetzer do you support installions too?

jHetzer · December 13, 2019, 7:39pm

Happy to hear that. I would recommend you to use the develop branch with new improvements:

github.com/jHetzer/erpnextfints

Multi: Code re-design, refactoring, linting

committed 07:27PM - 13 Dec 19 UTC

jHetzer

+800 -293

- bump to version 0.2.0 - replace fints_wrapper with fints_controller - add bank…_account_controller and refactor - JS module for FinTS progressbar relates to FinTSInteractiv - add method docstrings (not completed) - start moving whitelist methods in client.py (single point of entry) - rename account_nr to account_iban (Patch) - extend "bank account" validation - follow PEP 8 -- Style Guide (not completed) - prepare for es/js-linting

Depends on what you mean

jHetzer · December 13, 2019, 8:52pm

Bank Account Wizard

wojosc · December 15, 2019, 7:01pm

I mean, do you help integrating the app and take a moment to introduce so we are able to use it and look out for things not to do.

We are happy to compensate on the matter.

jHetzer · December 17, 2019, 6:06pm

Sure, i will pm you