Error in Report Builder Submit Button

I am trying to build a custom report.
On clicking the Submit button on Pick Columns, I get the following JS error in the console
I tried it on two different instances, still getting the same error, not able to click on Submit

base_list.js:226 Uncaught (in promise) TypeError: Cannot read property ‘length’ of undefined
at frappe.views.ReportView.setup_filter_area (base_list.js:226)
14report_view.js:1104 Uncaught TypeError: Cannot read property ‘destroy’ of undefined
at frappe.ui.Dialog.primary_action (report_view.js:1104)
at HTMLButtonElement. (dialog.js:127)
at HTMLButtonElement.dispatch (jquery.min.js:3)
at HTMLButtonElement.r.handle (jquery.min.js:3)

1 Like

I too had this issue!

I fixed it by changing /apps/frappe/frappe/public/js/frappe/list/base_list.js:226

if (this.filters.length > 0) {
if (this.filters && this.filters.length > 0) {

This does not seem to be the way to go. Is there a way of fixing this correctly or is this a bug that will be fixed in a new release?

1 Like

That worked. We have a bug, seems someone forgot to verify that filters was not undefined/empty.

@rmehta, doe’s this need assignment to someone? or can I simply make a PR?

Note: This works fine on my production site running ERPNext: v11.1.25 (master), Frappe Framework: v11.1.26 (master). Breaking on frappe 11.1.26, a developer_mode enabled site without ERPNext.