Error NoneType when install custom app

rahy · August 30, 2020, 4:02pm

I have a custom app that worked before.
Yesterday I made some change and committed it to my repo.
And it still worked fine.

Today I made new site and install the customapp and got error message when doing this bench command:

$ bench --site site.name install-app customapp

the error is when updating Doctype half way (see the [===] isn’t finished)

Installing customapp...
Updating DocTypes for customapp : [===============                         ]
An error occurred while installing customapp:
expected str, bytes or os.PathLike object, not NoneType

What is this error?
How can I know what’s wrong?
Where is the process log? I see the bench.log doesn’t have the information.
Thank you

netchampfaris · August 31, 2020, 5:33pm

I agree there should be a traceback where the error occured. For now, try adding the traceback print manually.

Add the following line on line 221 in site.py:

print(frappe.get_traceback())

github.com

frappe/frappe/blob/develop/frappe/commands/site.py#L221


      
          
          
		# Rollback on unsuccessful decryrption
          		if not os.path.exists(sql_file_path):
          			click.secho("Decryption failed. Please provide a valid key and try again.", fg="red")
          
          
			_backup.decryption_rollback()
          			sys.exit(1)
          
          
		decompressed_file_name = extract_sql_from_archive(sql_file_path)
          
          
		if is_partial(decompressed_file_name):
          			click.secho(
          				"Partial Backup file detected. You cannot use a partial file to restore a Frappe site.",
          				fg="red",
          			)
          			click.secho(
          				"Use `bench partial-restore` to restore a partial backup to an existing site.",
          				fg="yellow",
          			)
          			_backup.decryption_rollback()
          			sys.exit(1)

Try installing your customapp again, the traceback should get printed.

If this worked for you, you can send a PR with that print statement, it might be useful to others too.

rahy · August 31, 2020, 7:25pm

Yes. thank you for that.
Silly me… I was making my customapp logging and unaware that I set the log file path from a field within the custom app itself

I will send PR for this useful line.