Expired Batch Purchase/Sales Return

fkardame · May 23, 2019, 11:30am

Purchase Invoice/ Purchase Receipt are not allowed to accept Expired Batch Items that is a good validator, but keeping the same validator for Returns is not a good idea. Well I cannot find anyway to return expired items to the supplier.

Similar way,

Sales Return,
I am not able to make sales returns for expired items, I think the validator needs to be disables when the ‘Is Return’ is checked.

Currently i just change the batch expiry and process the document and then change the expiry back to is original which is just a workaround and not a good way to show to clients.

I think Erpnext team needs to look into this. I will also try to add this to issues and ask my development team to look into this and find a way to solve.

The reason to post here is to Check with the community if they have the same concern and what are the ways they are solving this concern.

fkardame · June 2, 2019, 12:08pm

Anyone have any idea about this?

Now we’re getting many returns to process with expiry and we cannot keep changing the expiry dates.

nabinhait · June 6, 2019, 4:38am

Please create a github issue explaining the scenario.

aliriocastro · September 11, 2019, 2:29pm

I am having exactly the same situation. Actually expired batch item should be able to be sold because it will depend on seller criteria.

fkardame · September 11, 2019, 3:50pm

Yes there need to be toggle switch to do this. I dont see any interest from the core team nor the community except few of us.

aliriocastro · September 11, 2019, 4:55pm

I found that the team hardcoded the SQL statament that query for batchs on all docs.

github.com

frappe/erpnext/blob/e3ef56804cc7364dcd281f145970cff9200588da/erpnext/stock/doctype/batch/batch.py#L255


      
          			break
          
          
	if not batch_no:
          		frappe.msgprint(_('Please select a Batch for Item {0}. Unable to find a single batch that fulfills this requirement').format(frappe.bold(item_code)))
          		if throw:
          			raise UnableToSelectBatchError
          
          
	return batch_no
          
          

          
def get_batches(item_code, warehouse, qty=1, throw=False):
          	batches = frappe.db.sql(
          		'select batch_id, sum(actual_qty) as qty from `tabBatch` join `tabStock Ledger Entry` ignore index (item_code, warehouse) '
          		'on (`tabBatch`.batch_id = `tabStock Ledger Entry`.batch_no )'
          		'where `tabStock Ledger Entry`.item_code = %s and  `tabStock Ledger Entry`.warehouse = %s '
          		'and (`tabBatch`.expiry_date >= CURDATE() or `tabBatch`.expiry_date IS NULL)'
          		'group by batch_id '
          		'order by `tabBatch`.expiry_date ASC, `tabBatch`.creation ASC',
          		(item_code, warehouse),
          		as_dict=True
          	)

So, there is no option to override this behavior unless the team changes this.

Alirio.

fkardame · September 11, 2019, 5:07pm

Oh thanks for pointing it out.
Maybe you should make an github issue and follow up with it. I will up it for you.

aliriocastro · September 11, 2019, 6:33pm

Thanks for your attention,

Will you post the github issue?

fkardame · September 12, 2019, 2:24pm

Git Issue on ERPNext.
https://github.com/frappe/erpnext/issues/19029

Thomas_M · April 2, 2020, 12:13pm

Hi,

What’s the update on this issue?

When trying to submit a Stock Reconciliation to account for lost stock, it will not accept because of the expired date, which of course is the reason to book it as lost stock.

fkardame · April 3, 2020, 1:16am

No update. I have asked my developer to look into it. As we cannot wait for erpnext team anymore as we rarely get any response from them even though we only try to correct the practical issues.

aliriocastro · May 25, 2020, 4:04pm

I did. I just deleted the condition that skip expired items.