[Feature Request] Sales Order from Quotation with a different currency

federico_calvo · August 14, 2018, 3:42pm

Hi, there is the possibility to add a configuration in Selling that allows changing the currency from previous docs?

If the configuration is set, the filter [“currency”, “=”] in the following method must be removed.

We can contribute with a PR.

frappe/erpnext/blob/develop/erpnext/selling/doctype/sales_order/sales_order.py#L145


      
          					(d.prevdoc_docname, self.order_type),
          				)
          				if not res:
          					frappe.msgprint(_("Quotation {0} not of type {1}").format(d.prevdoc_docname, self.order_type))
          
          
	def validate_delivery_date(self):
          		if self.order_type == "Sales" and not self.skip_delivery_note:
          			delivery_date_list = [d.delivery_date for d in self.get("items") if d.delivery_date]
          			max_delivery_date = max(delivery_date_list) if delivery_date_list else None
          			if (max_delivery_date and not self.delivery_date) or (
          				max_delivery_date and getdate(self.delivery_date) != getdate(max_delivery_date)
          			):
          				self.delivery_date = max_delivery_date
          			if self.delivery_date:
          				for d in self.get("items"):
          					if not d.delivery_date:
          						d.delivery_date = self.delivery_date
          					if getdate(self.transaction_date) > getdate(d.delivery_date):
          						frappe.msgprint(
          							_("Expected Delivery Date should be after Sales Order Date"),
          							indicator="orange",

Thanks!

rmehta · August 16, 2018, 4:54pm

What is the use case for this?

federico_calvo · August 16, 2018, 5:29pm

Hello Rushabh.

In our country (Argentina), as in others countries in South America, the inflation and devaluation are constant.

Because of this, is common to create a Quotation in dollars but make the Sales Order and Sales Invoice in pesos (local currency).

In order to maintain the traceability of the Quotation > Sales Order > Sales Invoice, we need to have the option of changing the currency despite the previous document.

Thanks.

clarkej · August 16, 2018, 5:37pm

Yes Venezuela in particular -

"
By the end of 2018, the inflation rate in Venezuela will surge to 1,000,000%—yes, 1 million percent—according to the International Monetary Fund.
"

aakvatech · January 16, 2019, 11:28am

For countries in Africa it is very common to create sales orders in USD and also sales invoices in USD, then ( to make it more interesting) we issue a govt based tax invoice using govt authorized POS terminal in base currency (local currency).

This is what also explained in the post addressed in Best Practice to Handle Multi-currency Supplier and Customer - #4 by aakvatech

federico_calvo · January 16, 2019, 1:51pm

My team made a pull request and its merged today.

github.com/frappe/erpnext

fix: Quotation to Sales Order with different currency

frappe:hotfix ← fproldan:quotation-currency

opened 03:32PM - 14 Jan 19 UTC

Don-Leopardo

+21 -1

This small fix allows the user to create Quotations in a specific currency and, …from them, create Sales Orders with a different currency, being able to track the Quotations. For example: You can create a quotation with a price list in USD and then create a Sales Order for that quotation in ARS. This use case is very common in countries with a high inflation rate where you make the quotations in USD but you receive the money in your country currency (CC). We do this because if we make them in our CC, tomorrow, when we make the Sales Order we are going to lose money because our CC has less value than before.

Regards

aakvatech · January 16, 2019, 2:28pm

We have to make an unrealized exchange gain / loss facility for such items so that it can be reported for accounting as well. We are already able to raise sales invoice in foreign currency and then receive the monies with converted rate to company currency.

aakvatech · April 7, 2019, 7:44pm

https://discuss.frappe.io/t/unrealized-exchange-gain-and-loss-per-sales-purchase-invoice/

This is what has been done.