Fetching items of one doctype from another doctype

letayt · May 26, 2017, 5:38am

I have created a new doctype “bid” in buying module and i want to fetch lits of bid doc type from the purchase order doctype using the “get items from” button same as get items from material request and supplier quotation. please can any one help me how to proceed.

Thank you for your help.

creamdory · May 26, 2017, 5:41am

Hi @letayt! you just have to make sure that field for “bid” is present in this doctypes with exactly the same name. When you use the button “get items from”, it will automatically get all the info from the doctype you are getting and setting it to the current doctype as long as the field exists.

letayt · May 26, 2017, 9:03am

Thanks for your reply @creamdory. to make more clear, i have created the button bid Management as shown in the image below.

on clicking the bid management button it will not bring the list rather it gives me the option to create new bid managementand am confused what to do

creamdory · May 27, 2017, 2:28am

Hi @letayt! Can you let us see your script for the “Get From Bid Management” dialog? Let’s see if you have set query to the dropdown field.

fahimalizain · May 27, 2017, 3:02am

Hii @letayt
This is how items from Supplier Quotation is mapped into Purchase Order.

A custom buttons is added with a function calling map_current_doc with query filters

github.com

frappe/erpnext/blob/develop/erpnext/buying/doctype/purchase_order/purchase_order.js#L175


      
          				allow_receipt = true;
          			} else {
          				is_drop_ship = true;
          			}
          
          
			if(is_drop_ship && allow_receipt) {
          				break;
          			}
          		}
          
          
		this.frm.set_df_property("drop_ship", "hidden", !is_drop_ship);
          
          
		if(doc.docstatus == 1) {
          			this.frm.fields_dict.items_section.wrapper.addClass("hide-border");
          			if(!this.frm.doc.set_warehouse) {
          				this.frm.fields_dict.items_section.wrapper.removeClass("hide-border");
          			}
          
          
			if(!in_list(["Closed", "Delivered"], doc.status)) {
          				if(this.frm.doc.status !== 'Closed' && flt(this.frm.doc.per_received) < 100 && flt(this.frm.doc.per_billed) < 100) {
          					// Don't add Update Items button if the PO is following the new subcontracting flow.

A python mapping function is given as a parameter to map_current_doc
Its this python function in the case of Supplier Quotation

github.com

frappe/erpnext/blob/develop/erpnext/buying/doctype/supplier_quotation/supplier_quotation.py#L67


      
          
          
	def validate_valid_till(self):
          		if self.valid_till and getdate(self.valid_till) < getdate(self.transaction_date):
          			frappe.throw(_("Valid till Date cannot be before Transaction Date"))
          
          
	def update_rfq_supplier_status(self, include_me):
          		rfq_list = set([])
          		for item in self.items:
          			if item.request_for_quotation:
          				rfq_list.add(item.request_for_quotation)
          		for rfq in rfq_list:
          			doc = frappe.get_doc("Request for Quotation", rfq)
          			doc_sup = frappe.get_all(
          				"Request for Quotation Supplier",
          				filters={"parent": doc.name, "supplier": self.supplier},
          				fields=["name", "quote_status"],
          			)
          
          
			doc_sup = doc_sup[0] if doc_sup else None
          			if not doc_sup:
          				frappe.throw(

Try to identify the pattern that is used in mapping the doc.
You can refer other doctypes also, like Sales Invoice Sales Order relationship etc.

Hope it helps
Thank you

Taher_Khalil · October 25, 2017, 12:32pm

Hi @creamdory , sorry for referencing a question of other post but could you please tell me how can you get the doctypes list in python script.
Like i want to check on a custom doctype on validate if a item of that name is present.
How could i get and compare all item names with the field? -
i did item_doctype = frappe.db.sql("select name from tabItem") but that doens’t give me the right answer on if not package_item in item_doctype: as the query returns in tuple format.
then i saw you post Fetch value of fieldname from another doctype - #7 by creamdory
and thought if i can get it in a object i can maybe do something like if not package_item in item_doctype.item_code:
but how would i write the query or achieve this?

Thanks and sorry for explicit mention.