Frappe Docker Custom app override_whitelisted_methods not loaded

meaziz · September 21, 2021, 10:02am

Somehow we manage to override whitelisted methods in the Frappe app in our development environment but when we build the custom-app wrapper container and deploy it it doesn’t seem to register that override.

the original code gets loaded.

 override_whitelisted_methods = {    
"frappe.event_streaming.doctype.event_consumer.event_consumer.register_consumer": "custom_app.event_streaming_overrides.register_consumer"
}

revant_one · September 21, 2021, 11:30am

can you create a repo that reproduce your issue?

meaziz · September 23, 2021, 8:19am

I’ll setup a git repo to be able to share that. Anyway will share the repo once it is setup.

By the way I followed that repo GitHub - castlecraft/custom_frappe_docker but installed two custom apps which should be ok as well .

What is also strange though I tried to build a stack based on a frappe fork and not bother much with the whitelisted override but still my fork code is not executed when the call is an API call made by the FrappeClient module from another instance.

I’m way confused about that.

revant_one · September 23, 2021, 9:57am

With custom_frappe_docker as well as methods given in official frappe_docker the official frappe repo is used.

The base image built for frappe is from official repo. So If you use frappe/frappe-worker as your base image it’ll always give you official frappe.

You’ll have to build from frappe forks separately. Check these build-arg(s) how the feature review system does it.

github.com

revant/erpnext_feature_board/blob/c645c6d18702010c91b1fab41d260c56d5914ca7/erpnext_feature_board/clients/k8s.py#L63


      
          	body = client.V1Job(api_version="batch/v1", kind="Job")
          	body.metadata = client.V1ObjectMeta(
          		namespace=get_namespace(),
          		name=job_name,
          	)
          	body.status = client.V1JobStatus()
          	volume_mounts = None
          	volumes = None
          	host_aliases = None
          
          
	worker_args = [
          		f"--dockerfile=build/{improvement.app_name}-worker/Dockerfile",
          		"--context=git://github.com/frappe/frappe_docker.git",
          		f"--build-arg=GIT_REPO={git_repo}",
          		f"--build-arg=IMAGE_TAG={image_tag}",
          		f"--build-arg=GIT_BRANCH={git_branch}",
          		f"--destination={get_container_registry()}/{improvement.app_name}-worker:{improvement.name}",
          	]
          	nginx_args = [
          		f"--dockerfile=build/{improvement.app_name}-nginx/Dockerfile",
          		"--context=git://github.com/frappe/frappe_docker.git",