Guide for volunteers

[revant_one]

Forum

• Only posts which are marked Solved or which are Closed are resolved. All other posts need your help.
• Raise github issue if needed.
• If there is already an issue on the post check whether it is closed. Close posts with resolved issues

Github Issues

• Tag issues from available labels
• Module Team can propose a milestone on github issue.
• Add set of issues to be added to milestone on the Proposed Milestone issue.
• On agreement the proposed milestone issue will be closed and milestone will be created.
• Request permission to Label Github issues
  • Volunteers Github Team for Frappe and ERPNext
  • Volunteers Github Team for Foundation Repo

PR Approval and Merging

• Volunteers check and approve PR for:
  • Functionality (Generally approved by module leader)
  • Code and naming conventions. (tabs, spaces, indentation, variable naming etc.)
  • Automated Tests (Server side and UI)
  • Documentation (docs / forum / github wiki, etc.)
  • Manual Tests - [How To] Testing a Pull Request
• Even if you use PR Approve Feature of github. Write a comment in PR Conversation, what you approve (Functionality / Code / Automated Tests / Docs / Manual Test) and other details regarding approval
• You can counter previous approvals if you find something wrong while you test.
• Final decision for merging will remain with frappe core team.

Github Milestones

• Module volunteers meet on call Weekly or Fortnightly
• Discuss one month roadmap for module
• Module Milestone will be created for the Month
• 5-6 Issues per Module Milestone
• Discussion and proposal on discuss.frappe.io
• Github issue created for detailed specifications
• Dummy data files (xlsx, csv, txt) share on google drive/dropbox and post link on issue
• Private group on discuss forum will be created as per request. Module Leaders can contact @revant_one

[revant_one]

Concern which was shared with me.

@mdwala

Post having 1 or more reply involved, which are not helpful to solve posted query, will not receive any new message from new-knowledgeable members.

Why? - Because they tend to see if even one person answered to a post, volunteer may just ignore and think it’s been taken care of.

But that person who replies 1st in a post, just might not know much further for how to solve.

Community members needs to change this. Post having one or more reply doesn’t mean it is solved.

[revant_one]

Should there be mentions for module volunteer?

Notification badges help me know who needs help on which topic. I’d encourage tagging a volunteer on public topics. After all it is choice of volunteer to respond or ignore.

[mdwala]

Hi @revant_one
I have few more suggestions:
You may delete this post and if agree add to main wiki.

1. Every contributor should add Github username next to their name & also if service provider: Name of the company. Ex- Mohd - mdwala - Alex Co. (This will generate little attention to user that which service provider helped him, and his activity with core. Same way it will help service provide to gain interest in user). Not sure if can add it with username intead of name.

2. On Service provider page - Every Service Provider must provide their discuss user-name along with their name. Optional Github username too. (Will help users indentify good developer and this is only way to do this)