Help us build the PR Review System

I believe, in the process that @revant_one and @RohanB have brainstormed, the individual business users will be able to add their voice to the process. In offline discussions, @RohanB had already suggested that all of this take place here on the forum.

To that end goal, we are already working out how to easily identify the forum threads that will be relevant to each of the testing cases. Everything is still in early stages right now and yet we already have 2 test systems available for any user to test and experience the changes for themselves.

We would certainly like to have you join us as a specialist in supply chain and accounting improvements that show up in this new process. It is the experienced business users like yourself that can help bring clarification to this process.

The only thing that may be uncomfortable for them at this time is the lack of official tools of analytics or standardized specifications. While large corporate business users may understand those things, the smaller business users may not have a great deal of exposure to those tools. It would be up to us to help them express what they want in the clearest terms possible so the volunteer developers can understand “at-a-glance” exactly what is needed.

BKM

7 Likes

@revant_one This is such a welcome initiative. I wish I could give this post 10x :heartbeat:
I firmly believe that there are many domain experts using ERPNext whom now have the mechanism to contribute meaningfully. Thanks so much for bringing this capability to fruition.

1 Like

Hi,
One important point, PR use case should be assigned an owner who is leading test and merge since we are community based sometimes things get lost in between contributors, for any reason also valid reasons project engagement or what ever.

PR test owner will follow PR till the end or find another owner to do handover.

rgds

1 Like

Rohan figured out discourse integration

1 Like

So our current idea is to create a Discuss post everytime a build succeeds on the server (we’re only doing builds via manual requests right now to save server resources).

The Discuss post will contain some basic information about the Github PR (along with a description if it has one) and also provide a way to access the testing site.

Discourse Post Example Image

https://user-images.githubusercontent.com/13396535/121903122-9b7c8a80-cd45-11eb-8849-d18ee9b8aee7.png


This really sounds like a policy change. Automatically tagging both the requesters and the contributors with users across Github and Discuss is going to be a bigger problem.

The next best thing right now should be the Discuss post I shared above, where anyone can go in and test, and leave their feedback for the contributor(s).

Do let us know what you think, and we’d appreciate feedback on any improvements to be made.

3 Likes

This is a great Initiative and it might help us be part of the development process. An option to contribution (or atleast an opportunity to contribute) is now available at PR level.

4 Likes

Updates,

I added listing and details page for Improvement, check https://board.castlecraft.co.in. Guest Users can list, filter and view improvements.

Request to Review flow is up.

  1. Login with Google (Internal Test OAuth Client registered with google)
  2. Select any improvement (Merged ones also exist github delete merged Improvement(s) · Issue #28 · revant/erpnext_feature_board · GitHub)
  3. User can select request type and request to review
  4. The request will be visible under selected improvement for logged in user

This will create requests that mods can delete, approve or reject from desk view.
Flow for mods to take actions is not yet added. Review Requests Logic · Issue #27 · revant/erpnext_feature_board · GitHub

Hi @revant_one,

Do you think this could apply as PR?

I haven’t received any useful answer and I’m sure this tool worked as explained, I used it all the time before upgrade to v11.

PR means Pull Request. If you fix the issue on your own in your frappe / erpnext fork code hosted on your server and it works for you and if you wish to share that with everyone you can send it as a PR. This is where you contribute to core.

In case you just need to solve the problem immediately, the issue seem to be around the “Supplier Quotation Comparison” report. Copy that report in separate custom app, rename it, make changes you need. This is where you create your custom app.

By looking at the closed Issue I feel there is gap between developer’s expectation from the feature and your expectation from the feature. That might take time to resolve. You can choose custom app option to solve your problem immediately.

2 Likes

Is the PR review system facing any issues?
Getting 404s when accessing the PR test sites.

Only the Improvement(s) with “Deployment Status” that is “Ready” will have a website.

check the ones with ready here: https://board.castlecraft.co.in sort by deployment status and you will see. Right now only 1 is running https://board.castlecraft.co.in/improvement?name=GH-IMP-2021-00192

I scaled down the cluster to 2 nodes to save some credits.

I didn’t know people are really using this! that is great!

3 Likes

What are the login credentials for this instance?
It would be great, if credentials are shown in the board itself for each instance.

The link if anyone is looking for this one PR. Dont know the u/password
https://gh-imp-2021-00192.castlecraft.co.in/#login

got to any ready instance

click on Review Request:

Select Add Testing User:

Click on the user to see password

Moderator has to approve this request, If you do it now, I’ll approve immediately.

If you want a site for this PR then click “Request to Review” and select “Build”, It’ll be in for moderation again.

“Request to Review” button seems to be restricted to logged in users only and I am unable to sign up using email.

can you signin with google?

I’ve not set email account. I don’t wish to add my email account.

This PR was tested using the system. Now it is merged.

4 Likes

Click here if you find it useful https://board.castlecraft.co.in/donate-and-support