wale
June 12, 2017, 9:00am
1
Hi all,
How can a customer on the ERPNext cloud add a custom method? Basically, there’s an existing standard method that almost suits our requirement but just needs a little tweaking. I’m guessing we’ll have to copy the existing method, make the adjustments, and then add it as a custom method
Please advise
Thanks
rmehta
June 12, 2017, 9:00am
2
Yes, by sending a pull-request
wale
June 12, 2017, 9:06am
3
Hi @rmehta
Nice one!
I guess it’s about time I learnt how to do this. Hope it’s not as complicated as it looks
Kind regards,
wale
June 14, 2017, 11:34am
4
Hi @rmehta
Trust you’re doing great. Don’t I need some form of permission to send a pull request?
Also, is there any step by step guide for doing this? Would appreciate any assistance
Thanks
Briefly,
Fork project on Github.
In your local repo dir add your fork as remote. (refer Testing pull request post)
make changes and push to your remote.
Create Pull request from your branch with changes to upstream/branch
Github help
https://help.github.com/articles/creating-a-pull-request/
Related Posts
Summarizing
git remote add upstream https://github.com/frappe/manual_erpnext_com.git
git pull --rebase upstream master
If you find conflicts, then resolve them in the file and then
git add .
git rebase --continue
@revant_one Thanks for contributing Just accepted your pull request.
There is no right answer, but you can keep pushing to the same branch / pull request as long as the pull request is open.
Or you can make a new branch for each update.
Make sure to rebase using git pull --rebase upstream master regularly!
Prerequisites
Working frappe-bench with erpnext and frappe installed. Installed apps, Frappe and ERPNext must be on develop branch. (Generally feature pull requests are in develop branch)
refer bench readme
Steps :
change to app’s directory and add git remotes/branches
follow these commands for erpnext:
~/frappe-bench$ cd apps/erpnext
~/frappe-bench/apps/erpnext$ git remote add mntechnique https://github.com/mntechnique/erpnext
~/frappe-bench/apps/erpnext$ git fetch mntechnique --unshallo…
1 Like
wale
June 15, 2017, 9:24am
6
Hi @revant_one
Thanks for your helpful reply. I’ll follow your guidelines and revert if I need further clarifications
Kind regards,