ie i want Tasks that are either Open or Overdue. The original filtering functionality allowed one to ‘edit’ a filter to add an ‘OR’ but I can’t see how to do this now.
If I add two filters one for Tasks Status of Open and one for Tasks Status of Overdue then its doing an ADD, ie any tasks have to be both Open AND Overdue which brings up no tasks at all
clarkej
September 11, 2017, 1:17pm
2
Yes, to OR together search filter clauses would be excellent, a bit odd that composite function is omitted.
“The original filtering functionality allowed one to ‘edit’ a filter to add an ‘OR’ but I can’t see how to do this now.”
An old release had that - do you recall what version when?
The current docs note ‘You can apply multiple filters at a time’ but no note of OR
https://erpnext.org/docs/user/manual/en/using-erpnext/articles/search-filter ?
And these ‘multiple filter’ issue fixes do not complain about a missing ‘edit filter’ function
Multiple filter area fix by netchampfaris · Pull Request #3738 · frappe/frappe · GitHub
@umair sorry to bother you, please can you comment on this?
Is OR omitted for say performance reasons?
Thanks
Hello John
Thanks for this. The version with this was the one not so long back with the previous filters etc. Probably around 3 months ago at a guess.
Yes, I do think that there should be an ‘OR’ function for cases exactly as mine. Or al east an easy way to achieve same.
Julian
clarkej
September 11, 2017, 6:21pm
4
l suspect one of these broke things
https://github.com/frappe/frappe/pull/3553
https://github.com/frappe/frappe/commit/258ec9a5f9e93756d786b4c4fd8d3d4e5671a4b0
I fear no filter tests exist!?
frappe@erpnext:~/frappe-bench$ find . -name '*filter*.py'
./apps/frappe/frappe/patches/v7_2/remove_in_filter.py
./apps/frappe/frappe/patches/v7_2/set_in_standard_filter_property.py
./env/lib/python2.7/site-packages/IPython/core/tests/test_prefilter.py
./env/lib/python2.7/site-packages/IPython/core/prefilter.py
./env/lib/python2.7/site-packages/openpyxl/worksheet/filters.py
./env/lib/python2.7/site-packages/jinja2/asyncfilters.py
./env/lib/python2.7/site-packages/jinja2/filters.py
./env/lib/python2.7/site-packages/pyPdf/filters.py
./env/lib/python2.7/site-packages/pygments/filter.py
frappe@erpnext:~/frappe-bench$
clarkej
September 11, 2017, 7:03pm
5
I will look for tests here and let you know what I find…
Hello all,
In order to improve the stability on the UI side, we have added a new framework for UI testing.
Highlights
We are using QUnit to write the tests, Selenium with Chromedriver to run the tests.
All the tests will be in the tests/ui folder of the app
Tests will be run via a DocType Test Runner which will be called by Selenium on the CI. You can also test locally from the Test Runner interface
Lots of core functions have been changed to return Promise objects, so that they can be grace…
clarkej
September 12, 2017, 3:44pm
6
Please when you have a moment @makarand_b or @kolate_sambhaji
Is the OR operator, to join boolean clauses, in the search filter missing?
Julian and I suspect this went missing from the filter redesign.
I looked for an open ‘filter’ issue on github but found none.
For me to fix the UI or write a UI test to demo the bug would be a leap for me.
Thank you
clarkej
September 19, 2017, 10:36pm
7
ok so their is no actual ‘OR’ operator - at least not now.
kolate_sambhaji responded here Print Date & Time - #10 by kolate_sambhaji
that I also copied below:
I think its by design taking AND condition.
So if you want Overdue and Open Task you can use IN filter.
1 Like