IBAN number isn't valid

ahmedalisync · December 31, 2019, 3:28pm

When I try to add new bank account , whatever I put in IBAN Field there is massage The IBAN Number isn’t valid

clarkej · December 31, 2019, 6:08pm

Thanks for reporting this - here’s the validation code

frappe/erpnext/blob/develop/erpnext/accounts/doctype/bank_account/bank_account.py#L30


      
          		self.name = self.account_name + " - " + self.bank
          
          
	def on_trash(self):
          		delete_contact_and_address("BankAccount", self.name)
          
          
	def validate(self):
          		self.validate_company()
          		self.validate_iban()
          
          
	def validate_company(self):
          		if self.is_company_account and not self.company:
          			frappe.throw(_("Company is manadatory for company account"))
          
          
	def validate_iban(self):
          		"""
          		Algorithm: https://en.wikipedia.org/wiki/International_Bank_Account_Number#Validating_the_IBAN
          		"""
          		# IBAN field is optional
          		if not self.iban:
          			return

and a basic test

github.com

frappe/erpnext/blob/develop/erpnext/accounts/doctype/bank_account/test_bank_account.py#L15


      
          
          
import frappe
          from frappe import ValidationError
          
          
# test_records = frappe.get_test_records('Bank Account')
          
          

          
class TestBankAccount(unittest.TestCase):
          	def test_validate_iban(self):
          		valid_ibans = [
          			"GB82 WEST 1234 5698 7654 32",
          			"DE91 1000 0000 0123 4567 89",
          			"FR76 3000 6000 0112 3456 7890 189",
          		]
          
          
		invalid_ibans = [
          			# wrong checksum (3rd place)
          			"GB72 WEST 1234 5698 7654 32",
          			"DE81 1000 0000 0123 4567 89",
          			"FR66 3000 6000 0112 3456 7890 189",
          		]

To independently confirm that IBAN number is valid would be best to troubleshoot where the problem lies. For example here is a IBAN Checker: Validate & Check IBAN Number for Errors

This one IBAN checker: Validate an IBAN - Wise notes this:

“Your IBAN being in the right format isn’t a guarantee that it exists. Or that it represents the right destination.”

cheers

ahmedalisync · February 11, 2020, 1:05am

Mr Clarkej , thanks a lot for your effort , I checked an Iban number and when I entered it , the system saved it with no errors

Thanks again
Best regards
Ahmed

Crikey · May 19, 2020, 9:38am

This was exactly the information required. Thanks @clarkej
Just enter the iban number according to International Bank Account Number - Wikipedia and it works.

This topic could be marked with answer and closed?

clarkej · May 19, 2020, 12:07pm