Issue with frappe.realtime post migrate to v7

RobertSchouten · November 22, 2016, 2:45am

in my email inbox i use frappe.realtime to notify users when a new email arrives
it was working v6 but it’s not in v7
i know the implementation needs to b refined to reduce traffic but is a temp solution

github.com

indautgrp/frappe/blob/email-inbox/frappe/email/doctype/email_account/email_account.py#L271


      
          							if not communication.timeline_hide and not communication.unread_notification_sent:
          								communication.notify(attachments=attachments, fetched_from_email_account=True)
          
          
			#update attachment folder size as suspended for emails
          			try:
          				folder = frappe.get_doc("File", 'Home/Attachments')
          				folder.save()
          			except:
          				print("file attachment bug")
          				#exceptions.append(frappe.get_traceback())
          
          
			#notify if user is linked to account
          			if len(incoming_mails)>0 and not frappe.local.flags.in_test:
          				frappe.publish_realtime('new_email', {"account":self.email_account_name,"number":len(incoming_mails)})
          
          
			if exceptions:
          				raise Exception, frappe.as_json(exceptions)
          
          
	def handle_bad_emails(self,email_server,uid,raw,reason):
          		if cint(email_server.settings.use_imap):
          			import email

client side

github.com

indautgrp/inbox/blob/v7/inbox/email_inbox/page/email_inbox/email_inbox.js#L61


      
          					start: 0,
          					show_filters: true,
          				});
          			this.filter_list.add_filter("Communication", "deleted", "=", "No")
          			this.render_headers();
          			this.render_footer();
          			this.run()
          			this.render_buttons();
          			this.init_select_all();
          			var me = this;
          			frappe.realtime.on("new_email", function(data) {
          				for(var i =0;i<me.accounts.length;i++) {
          					if (data.account == me.accounts[i].name) {
          						frappe.utils.notify(data.account, "you have "+data.number+" new emails", {}, function () {
          							window.focus();
          							me.account = data.account;
          							$(me.page.sidebar).find(".list-row").removeClass("list-row-head").css("font-weight","normal");
          							$('.inbox-item[data-account="' + data.account + '" ]').closest(".list-row").addClass("list-row-head").css("font-weight","bold");
          							me.refresh();
          						});
          						if(!me.fresh &&(data.account == me.account ||me.account == me.allaccounts)) {

only change that appears related
frappe/frappe@a987e32

umair · November 22, 2016, 7:31am

@shreyasp please answer.

RobertSchouten · November 24, 2016, 5:38am

hmm seems to b a global thing when in develop mode it doesnt work

sivankar · July 27, 2018, 9:47am

Hi,

frappe.publish_realtime(‘foobar’, {‘data’: ‘abc’}), this seems to work if my site name and url are same, for example site name: site1.local and url site1.local\abc

but if i my site name: site1.local and url is local-run\abc and i have a etc/hosts entry for local-run it doesn’t work.

there are no error msg. is this the right behavior or is there something that im missing.