Items with quotes or percentage are not recognized by online POS or item master

Taher_Khalil · February 4, 2018, 1:44pm

I Had variants created in System as inches with symbol [ " ] but after upgrade to v10 , when entering barcode of those items items , items are not fetched ,

More over when clicking the name on items , it gives cannot find error as it doesn’t load the name in URL , i have to then manually type the remaining part to get the item .

see below e.g

Thanks

nabinhait · February 5, 2018, 5:46am

Can you please create a github issue for this?

Taher_Khalil · February 5, 2018, 8:19am

github.com/frappe/erpnext

[BUG]Items with Quotes(") or percentage (%) in naming are not recognized by online POS or item master

opened 07:50AM - 05 Feb 18 UTC

closed 07:33AM - 19 Feb 18 UTC

taherkhalil

bug stock POS

Suddenly in the latest version items are not getting recognized , on further ana…lysis found that all items which were initially created with a % or " in thier names are not getting detected in POS and cant access in item master . More details are on https://discuss.erpnext.com/t/items-with-quotes-or-percentage-are-not-recognized-by-online-pos-or-item-master/33471 Thanks

clarkej · February 8, 2018, 8:48pm

Are you self hosted? Please include a traceback to help your case…

Taher_Khalil · February 9, 2018, 4:28pm

Yes ,
There is no traceback which appears , take for example this item

When you click on it , the address bar doesn’t load the whole name like this -

Without the the parts in quotes "107" and hence shows

Only after entering the “107” manually in the address bar , item loads.
Same is case for items with single quote " , percentage (%).

This problem prevents it from loading in the online POS when its barcode is scanned.

Thanks

clarkej · February 9, 2018, 7:03pm

No problem here to save and display an Item code with metacharacters…

frappe@erpnext:~/frappe-bench$ bench version
erpnext 10.0.4
frappe 10.0.5

Have you tested import and export?

clarkej · February 9, 2018, 9:35pm

To get a traceback for debug purposes, my guess is add a throw “hello world” in show: or with_page: (before frappe.show_not_found) frappe/pageview.js at develop · frappe/frappe · GitHub

clarkej · February 10, 2018, 6:56pm

Some notes -

My guess is the ‘route string’ that encodes the item page spec is broken in V10, so metacharacters in the item code now cause the page render error.

frappe@erpnext:~/frappe-bench$ find . -name ‘*.js’ | xargs grep get_route_str

This to me is intriguing and pivotal

github.com

frappe/frappe/blob/develop/frappe/public/js/frappe/request.js

// Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
// MIT License. See license.txt

// My HTTP Request

frappe.provide("frappe.request");
frappe.provide("frappe.request.error_handlers");
frappe.request.url = "/";
frappe.request.ajax_count = 0;
frappe.request.waiting_for_ajax = [];
frappe.request.logs = {};

frappe.xcall = function (method, params) {
	return new Promise((resolve, reject) => {
		frappe.call({
			method: method,
			args: params,
			callback: (r) => {
				resolve(r.message);
			},

This file has been truncated. show original

Perhaps this is a worthy smoketest detector case to supplement these basic tests found here?

apps/erpnext/erpnext/accounts/page/pos/test_pos.js
apps/erpnext/erpnext/accounts/doctype/pos_profile/test_pos_profile.py
apps/erpnext/erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py

@kolate_sambhaji @utkarsh_goswami and @vishdha is this a practical case to implement a test, first to reproduce the error then as the basis for a fix!?