Hello My friends…
Hello, I also was looking for the solution and now came up with a small app to,
Leave Application with half day, the half day can be 1-7 hours choice, Leave Ledger Entry can be booked in the fraction of hours / 8.
But the Attendance will still be just Half Day (to minimize complexity).
So, for now, it works only on Leave Application, I have not tested with other use case, i…e, compensation leave request, etc.
If anyone try it and got bugs, let me know. Thanks.
[image]
[image]
Thanks in advance.
kittiu
December 23, 2024, 11:32am
2
Can you give example, why is it not working?
@kittiu I take the modification in the Leave_application.py here
committed 07:07PM - 15 Dec 24 UTC
fix indent of lines and add miss casting for "half_day_hours"
and changed my Leave_application_py file based on it.
kittiu
December 23, 2024, 1:42pm
4
Huh, I am a bit confused. I already merged this PR as per your suggestion.
kittiu:main ← ahmedusama250:main
opened 08:01PM - 11 Dec 24 UTC
…ys): Ensure half_day_hours defaults to 4 when None to prevent TypeError during … leave calculations.
This commit resolves a TypeError in the get_number_of_leave_days function by ensuring that half_day_hours defaults to 4 when it is None. This prevents the error that occurs when attempting to convert a NoneType to an integer.
Changes:
- Updated half_day_hours assignment to default to 4 if it is None.
- Adjusted number_of_days calculation accordingly.
This fix ensures that leave calculations function correctly even when half_day_hours is not explicitly set.
Closes TypeError: int() argument must be a string, a bytes-like object or a real number, not 'NoneType' in get_number_of_leave_days function #1
Note: I didn’t test it, just merge as I think it is not harmful. Is it not working as your expectation?
@kittiu Just to ensure that we are on the same page, after you added this script to Leave_Application.py, did you run a bench build and get this…?
Please note: this picture is not mine its from your last post about the same issue.
I change the file as you mentioned and then I run bench build and get this.
So, as you can see, nothing has changed in the forma. Is there anything else I need to do…?
kittiu
December 24, 2024, 6:30am
6
I think you just need to restart server for python to take effect. I not recon that we need to bench build.
Anyway, I have not look at this a while ago. I will test it again if the latest code is working.
@kittiu My question is, where did you get this picture from.? Did you apply the change that you made then you get it…? or did you add it from customize.?
