Leave application based on hours

Alexis_Dali · December 23, 2024, 7:20am

Hello My friends…
So I am trying to add leave based on hours, I follow this link but that’s not working for me, Please if anyone try this before.

Thanks in advance.

kittiu · December 23, 2024, 11:32am

Can you give example, why is it not working?

Alexis_Dali · December 23, 2024, 11:36am

@kittiu I take the modification in the Leave_application.py here

and changed my Leave_application_py file based on it.
then bench build and nothing changed in the leave application forma.
Please correct me if I am in the wrong way, or if I have to do something else.

kittiu · December 23, 2024, 1:42pm

Huh, I am a bit confused. I already merged this PR as per your suggestion.

github.com/kittiu/thai_leave

fix(fix: handle NoneType for half_day_hours in get_number_of_leave_da…

kittiu:main ← ahmedusama250:main

opened 08:01PM - 11 Dec 24 UTC

ahmedusama250

+2 -1

…ys): Ensure half_day_hours defaults to 4 when None to prevent TypeError during …leave calculations. This commit resolves a TypeError in the get_number_of_leave_days function by ensuring that half_day_hours defaults to 4 when it is None. This prevents the error that occurs when attempting to convert a NoneType to an integer. Changes: - Updated half_day_hours assignment to default to 4 if it is None. - Adjusted number_of_days calculation accordingly. This fix ensures that leave calculations function correctly even when half_day_hours is not explicitly set. Closes TypeError: int() argument must be a string, a bytes-like object or a real number, not 'NoneType' in get_number_of_leave_days function #1

Note: I didn’t test it, just merge as I think it is not harmful. Is it not working as your expectation?

Alexis_Dali · December 24, 2024, 5:44am

@kittiu Just to ensure that we are on the same page, after you added this script to Leave_Application.py, did you run a bench build and get this…?

Please note: this picture is not mine its from your last post about the same issue.

I change the file as you mentioned and then I run bench build and get this.

So, as you can see, nothing has changed in the forma. Is there anything else I need to do…?

kittiu · December 24, 2024, 6:30am

I think you just need to restart server for python to take effect. I not recon that we need to bench build.

Anyway, I have not look at this a while ago. I will test it again if the latest code is working.

Alexis_Dali · December 24, 2024, 6:43am

@kittiu My question is, where did you get this picture from.? Did you apply the change that you made then you get it…? or did you add it from customize.?
this one.

kittiu · December 25, 2024, 9:16am

Hello, sorry for messing up.

Now, I test it locally and force push the fix as following,

Would you try again.

Kitti

kittiu · December 25, 2024, 9:17am

Note: I think this requirement will be better if it could be in the core. As extension, there is no way but to use monkey patching, which I don’t really like.

gtapias · December 26, 2024, 1:29am

Hourly and by the minute leave is required by law for employees in many countries.

Core allowing this would be extremely beneficial to many.

kittiu · December 26, 2024, 4:06am

Thank you. Let’s see if there are more confirmation to this requirent and I will try to propose into core.