Migrating from v10 to v12

josmeldiaz21 · October 11, 2019, 6:35pm

I am migrating from v10 to v12 and I got the error in this patch

erpnext.patches.v12_0.move_item_tax_to_item_tax_template

I came from this topic, but no solution

this is the traceback.

Executing erpnext.patches.v12_0.move_item_tax_to_item_tax_template in site1.local (_8f1d7926f44aabff)
Traceback (most recent call last):
  File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/utils/bench_helper.py", line 97, in <module>
    main()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/utils/bench_helper.py", line 18, in main
    click.Group(commands=commands)(prog_name='bench')
  File "/home/frappe/frappe-bench/env/lib/python3.6/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/home/frappe/frappe-bench/env/lib/python3.6/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/home/frappe/frappe-bench/env/lib/python3.6/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/frappe/frappe-bench/env/lib/python3.6/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/frappe/frappe-bench/env/lib/python3.6/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/frappe/frappe-bench/env/lib/python3.6/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/home/frappe/frappe-bench/env/lib/python3.6/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/commands/__init__.py", line 25, in _func
    ret = f(frappe._dict(ctx.obj), *args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/commands/site.py", line 233, in migrate
    migrate(context.verbose, rebuild_website=rebuild_website, skip_failing=skip_failing)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/migrate.py", line 48, in migrate
    frappe.modules.patch_handler.run_all(skip_failing)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/modules/patch_handler.py", line 41, in run_all
    run_patch(patch)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/modules/patch_handler.py", line 30, in run_patch
    if not run_single(patchmodule = patch):
  File "/home/frappe/frappe-bench/apps/frappe/frappe/modules/patch_handler.py", line 71, in run_single
    return execute_patch(patchmodule, method, methodargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/modules/patch_handler.py", line 91, in execute_patch
    frappe.get_attr(patchmodule.split()[0] + ".execute")()
  File "/home/frappe/frappe-bench/apps/erpnext/erpnext/patches/v12_0/move_item_tax_to_item_tax_template.py", line 55, in execute
    item_tax_map, d.item_code, d.parent)
  File "/home/frappe/frappe-bench/apps/erpnext/erpnext/patches/v12_0/move_item_tax_to_item_tax_template.py", line 92, in get_item_tax_template
    "parent_account": parent_account
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 228, in insert
    self.run_before_save_methods()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 886, in run_before_save_methods
    self.run_method("validate")
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 786, in run_method
    out = Document.hook(fn)(self, *args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1056, in composer
    return composed(self, method, *args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1039, in runner
    add_to_return_value(self, fn(self, *args, **kwargs))
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 780, in <lambda>
    fn = lambda self, *args, **kwargs: getattr(self, method)(*args, **kwargs)
  File "/home/frappe/frappe-bench/apps/erpnext/erpnext/accounts/doctype/account/account.py", line 36, in validate
    self.validate_root_details()
  File "/home/frappe/frappe-bench/apps/erpnext/erpnext/accounts/doctype/account/account.py", line 92, in validate_root_details
    frappe.throw(_("Root Account must be a group"))
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 360, in throw
    msgprint(msg, raise_exception=exc, title=title, indicator='red')
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 346, in msgprint
    _raise_exception()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 315, in _raise_exception
    raise raise_exception(msg)
frappe.exceptions.ValidationError: Root Account must be a group

I look into the DB, and I found the records from tabItem tax

SELECT * FROM `tabAccount` 
where `name` IN (
	select tax_type
	from `tabItem Tax`
)

and I made them a group, but nothing happened.

Any Idea what’s going on here?

fkardame · October 11, 2019, 9:00pm

Why don’t you try to migrate to v11 first than move to v12, as I think there are major changes between v10 to v11 already and I am not sure of the patch was made for v10 to v12 jump.

josmeldiaz21 · October 14, 2019, 8:15pm

Thanks for you response, I did what you recomended, but I had the same result from v11 to v12.

frappe.exceptions.ValidationError: Root Account must be a group

any suggestion?

clarkej · October 15, 2019, 2:04pm

A code change like this would help identify the account in question -

github.com

frappe/erpnext/blob/develop/erpnext/accounts/doctype/account/account.py#L92


      
          
          
	def set_root_and_report_type(self):
          		if self.parent_account:
          			par = frappe.get_cached_value(
          				"Account", self.parent_account, ["report_type", "root_type"], as_dict=1
          			)
          
          
			if par.report_type:
          				self.report_type = par.report_type
          			if par.root_type:
          				self.root_type = par.root_type
          
          
		if self.is_group:
          			db_value = self.get_doc_before_save()
          			if db_value:
          				if self.report_type != db_value.report_type:
          					frappe.db.sql(
          						"update `tabAccount` set report_type=%s where lft > %s and rgt < %s",
          						(self.report_type, self.lft, self.rgt),
          					)
          				if self.root_type != db_value.root_type:

throw(_(“Account {0}: Root Account must be a group”).format(self.name)

josmeldiaz21 · October 15, 2019, 2:37pm

Thanks, it throw that account, let me continue searching… Thank u so much man.

josmeldiaz21 · October 15, 2019, 3:50pm

Well, After I found the Account, I realize that this account, wasn’t in my tabAccount table (in the new v12 server), I went to my v10 server and I look for it and it wasn’t there either, but when I look for that account in the ERPNext browser(v10), it was there, I just hit save, and it was saved in the database, I only copy that register in my v12 database and the error was gone.

I don’t know why that happened, because, it was a company that it wasn’t in use, and no change made since 2 years. but, it worked.

Thanks to all of you.